https://bugzilla.novell.com/show_bug.cgi?id=638090
https://bugzilla.novell.com/show_bug.cgi?id=638090#c4
--- Comment #4 from Ricardo Cruz
#include "gnomesu-auth-dialog.h" -#include "auth-icon.csource" #include "utils.h"
Does that mean we can remove all the stuff generating auth-icon.csource?
I think auth-icon.csource was manually generated. But yes, we can obliterate the thing.
I'd probably use the "dialog-password" icon name, which makes it possible to skip gtk_widget_render_icon() and call gtk_window_set_icon_name() for this case.
Oh, I only noticed the set_icon() and set_icon_list(). Yeah, we should do that. Not only does it save code, but it allows GTK to setup different sizes. (one for the window title, another for the Alt+Tab.) Anyhow, notice that GTK_STOCK_DIALOG_AUTHENTICATION is only a define for "gtk-dialog-authentication", so I'd rather use it, given GTK developers may have had flexibility in mind when doing that... #define GTK_STOCK_DIALOG_AUTHENTICATION "gtk-dialog-authentication"
+ gtk_window_set_icon (GTK_WINDOW (dialog), pixbuf); + g_object_unref (G_OBJECT (pixbuf));
In the case of
I think you were going to say I shouldn't had unref() it. You're right, the documentation doesn't say anything about it, but, looking at gtkwindow.c, it seems that the code doesn't increment the counter itself, as you'd expect in other contexts. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.