Mailinglist Archive: opensuse-bugs (10607 mails)

[bugzilla_noreply@xxxxxxxxxx]

http://bugzilla.novell.com/show_bug.cgi?id=533556

User trenn@xxxxxxxxxx added comment
http://bugzilla.novell.com/show_bug.cgi?id=533556#c41





--- Comment #41 from Thomas Renninger <trenn@xxxxxxxxxx>  2009-10-19 16:49:18 
MDT ---
Created an attachment (id=323137)
 --> (http://bugzilla.novell.com/attachment.cgi?id=323137)
Better ack the irq first...

Looking at the git history, this really should be it...,
Originally the ack was placed at the beginning which makes more sense (in
mce_intel_64.c):
1da177e4  (Linus Torvalds 2005-04-16 15:20:36 -0700       24) ack_APIC_irq();
95833c83  (Andi Kleen     2006-01-11 22:44:36 +0100       26) exit_idle();
1da177e4  (Linus Torvalds 2005-04-16 15:20:36 -0700       27) irq_enter();

Then it got moved to therm_throt.c, already the ack_APIC_irq has been put at
the end (after irq_exit()) and finally the misleading comment got added with
commit id a65c88dd2c83b569dbd13778da689861bdf977f2:
-       irq_exit();
-       ack_APIC_irq();
..
+       /* Ack only at the end to avoid potential reentry */
+       ack_APIC_irq();

Looks like someone else already run into this and only tried to fix the
message, last commit of therm_throt.c:
commit b417c9fd8690637f0c91479435ab3e2bf450c038
Author: Ingo Molnar <mingo@xxxxxxx>
Date:   Tue Sep 22 15:50:24 2009 +0200

    x86: mce: Fix thermal throttling message storm

    If a system switches back and forth between hot and cold mode,
    the MCE code will print a stream of critical kernel messages.

But this only suppresses some messages and does not fix the root cause ->
possible freeze after too many irqs.
Nothing for sure for now...

-- 
Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.