Mailinglist Archive: opensuse-bugs (5162 mails)

[bugzilla_noreply@xxxxxxxxxx]

http://bugzilla.novell.com/show_bug.cgi?id=520616


           Summary: [yast2-core] liby2dbus: invalid arguments do not
                    return dbus errors, only y2error and become nil
    Classification: openSUSE
           Product: openSUSE 11.2
           Version: Factory
          Platform: Other
        OS/Version: Other
            Status: ASSIGNED
          Severity: Normal
          Priority: P5 - None
         Component: YaST2
        AssignedTo: mvidner@xxxxxxxxxx
        ReportedBy: mvidner@xxxxxxxxxx
         QAContact: jsrain@xxxxxxxxxx
          Found By: Development


In liby2dbus there are many places where error conditions are only logged and
do not become dbus error replies.

Here is one case where a incorrect parameters got through to a method as nil:

rails error from the dbus client:
 NoMethodError (undefined method `[]' for false:FalseClass):
 lib/scr.rb:61:in `execute'
 app/controllers/permissions_controller.rb:17:in `get_permission_list'

y2log of the dbus service:
2009-07-07 12:51:39 <3> zofie(28243) [y2dbus] DBusMsg.cc(getYCPValueBsv):1126
Dunno how to translate BSV type  to YCP type
2009-07-07 12:51:39 <3> zofie(28243) [y2dbus]
DBusMsg.cc(getYCPValueRawType):946 Missing code to convert DBus data to YCP
type <unspec>
2009-07-07 12:51:39 <3> zofie(28243) [y2dbus]
DBusMsg.cc(getYCPValueRawType):952 Data mismatch, expecting YCP type <unspec>,
got DBus type s
--- the following errors are spurious, an error reply should have been sent by
now

2009-07-07 12:51:39 <3> zofie(28243) [y2dbus] DBusMsg.cc(getYCPValueBsv):1126
Dunno how to translate BSV type  to YCP type
2009-07-07 12:51:39 <3> zofie(28243) [y2dbus]
DBusMsg.cc(getYCPValueRawType):946 Missing code to convert DBus data to YCP
type <unspec>
2009-07-07 12:51:39 <3> zofie(28243) [y2dbus]
DBusMsg.cc(getYCPValueRawType):952 Data mismatch, expecting YCP type <unspec>,
got DBus type s
2009-07-07 12:51:39 <1> zofie(28243) [y2dbus]
DBusServerBase.cc(register_client):524 Registered a new client :1.180 (pid
26997)
2009-07-07 12:51:39 <3> zofie(28243) [Interpreter] :0 Bad command argument to
Execute (.bash, string command [, map env])
2009-07-07 12:51:39 <3> zofie(28243) [Interpreter] :0 SCR::Execute() failed

The client code is fixed by now,
http://git.opensuse.org/?p=projects/yast/rest-service.git;a=commitdiff;h=cd236c85c9e292590e8f56b882ce07ec94034a9c
but we need a more robust server.
Especially nested data structures may hide the errors as nils long enough to be
hard to debug.

-- 
Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.