Mailinglist Archive: opensuse-bugs (4174 mails)

[bugzilla_noreply@xxxxxxxxxx]

http://bugzilla.novell.com/show_bug.cgi?id=515024


           Summary: kradio-1.0beta3b_20060920-226.5: 2 * bad call to
                    delete
    Classification: openSUSE
           Product: openSUSE 11.2
           Version: Factory
          Platform: All
        OS/Version: openSUSE 11.1
            Status: NEW
          Severity: Normal
          Priority: P5 - None
         Component: KDE4 Applications
        AssignedTo: kde-maintainers@xxxxxxx
        ReportedBy: dcb314@xxxxxxxxxxx
         QAContact: qa@xxxxxxx
          Found By: ---


I just had a look at factory package kradio-1.0beta3b_20060920-226.5
In file kradio3/plugins/recording/encoder_ogg.cpp, around line 125
is the code

static void vorbis_comment_add_tag_new(vorbis_comment *vc, const QString &tag,
const QString &value)
{
    char *stag   = strdup(tag.ascii());
    char *svalue = strdup(value.utf8());
    vorbis_comment_add_tag(vc, stag, svalue);
    delete stag;
    delete svalue;
}

The return value from strdup should be freed by calling free(), not
by calling delete.

Suggest code rework.

-- 
Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.