Mailinglist Archive: opensuse-bugs (5007 mails)

[bugzilla_noreply@xxxxxxxxxx]

http://bugzilla.novell.com/show_bug.cgi?id=504325


           Summary: hercules-20080407-35.59: undefined code
    Classification: openSUSE
           Product: openSUSE 11.2
           Version: Factory
          Platform: All
        OS/Version: openSUSE 11.1
            Status: NEW
          Severity: Normal
          Priority: P5 - None
         Component: Other
        AssignedTo: bnc-team-screening@xxxxxxxxxxxxxxxxxxxxxx
        ReportedBy: dcb314@xxxxxxxxxxx
         QAContact: qa@xxxxxxx
          Found By: ---


I just tried to build Factory package hercules-20080407-35.59
and the build said

shared.c:2154: warning: operation on 'dev->shrdid' may be undefined

The source code is

        dev->shrdid = (++dev->shrdid) & 0xffff;

I agree with the compiler. Better code would be

        dev->shrdid = (dev->shrdid + 1) & 0xffff;

-- 
Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.