Mailinglist Archive: opensuse-bugs (16634 mails)

[bugzilla_noreply@xxxxxxxxxx]

https://bugzilla.novell.com/show_bug.cgi?id=416108

User pgajdos@xxxxxxxxxx added comment
https://bugzilla.novell.com/show_bug.cgi?id=416108#c13


Petr Gajdos <pgajdos@xxxxxxxxxx> changed:

           What    |Removed                                         |Added
----------------------------------------------------------------------------
                 CC|                                                
|lslezak@xxxxxxxxxx




--- Comment #13 from Petr Gajdos <pgajdos@xxxxxxxxxx>  2008-11-25 11:26:43 MST 
---
Because I don't see any other way I propose to simply drop support for
commented variable blocks in fillup: 

Every sysconfig file/template should contain only

--------------------------------------------------------
##
##  metadata block 1
##
#
# help block 1 -- with or without lines like # FOO=VALUE
#
FOO11=VALUE11  variable asignment block 1 *without* # FOO=VALUE,  
..            simply because # has a special meaning; 
FOO1N=VALUE1N  variable can be set empty by VARIABLE=

##
##  metadata block 2
..
..
..
FOOMN=VALUEMN  variable block M
--------------------------------------------------------

Further, I think deletion of variables should be prohibited or documented (if
it's not yet) too, because

## Type:        yesno
## Default:     yes
#
# help 1
# deleted FOO="value" from here

## Default:     no
#
# help 2
#
BAR="no"

will 
- break yast2 sysconfig help; whole block above BAR="no" will be taken
  as comment to BAR. Fortunately metadata are interpreted right way.
- lead to use FOO="new-value" from new sysconfig file during update. Merged
file can then look like

## Type:        yesno
## Default:     yes
#
# new help 1
FOO="new-value"

## Type:        yesno
## Default:     yes
#
# help 1
# deleted FOO="value" from here

## Default:     no
#
# help 2
#
BAR="no"

(So something not expected by user I guess.)

What do you think about it?


-- 
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.