https://bugzilla.novell.com/show_bug.cgi?id=416108 User pgajdos@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=416108#c10 Petr Gajdos <pgajdos@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nadvornik@novell.com Status|ASSIGNED |NEEDINFO Info Provider| |ro@novell.com --- Comment #10 from Petr Gajdos <pgajdos@novell.com> 2008-11-13 11:54:44 MST --- First problem I have met follows: for example block ----8<---------------------------------------------- ## Type: list(yes,no,int,ext,dmz,) ## Default: no # # 23.) # Specifies whether routing between interfaces of the same zone should be allowed # Requires: FW_ROUTE="yes" # # Set this to allow routing between interfaces in the same zone, # e.g. between all internet interfaces, or all internal network # interfaces. # # Caution: Keep in mind that "yes" affects all zones. ie even if you # need inter-zone routing only in the internal zone setting this # parameter to "yes" would allow routing between all external # interfaces as well. It's better to use # FW_ALLOW_CLASS_ROUTING="int" in this case. # # Choice: "yes", "no", or space separate list of zone names # # Defaults to "no" if not set # FW_ALLOW_CLASS_ROUTING="" ---->8----------------------------------------------- isn't interpreted as one CompleteVariableBlock, but as two blocks, - one CommentedVariableBlock ("\n## Type: ... # FW_ALLOW_CLASS_ROUTING="int" in this case.") and - one CompleteVariableBlock ("#\n# Choice: ... FW_ALLOW_CLASS_ROUTING="""). It turns out, that this case is actually not a problem, because FW_ALLOW_CLASS_ROUTING occurs once commented and once uncommented. But, think of _old_ file ------------------------------------- # FW_ALLOW_FW_BROADCAST_wlan="yes" # FW_ZONES="" FW_ALLOW_FW_BROADCAST_wlan="yes" and _new_ file -------------------------------------- # FW_ALLOW_FW_BROADCAST_wlan="yes" # FW_ZONES="" then _merged_ file by fillup -m is (in virtue of the fillup code) --------------------------------------- # FW_ZONES="" (Note, without comment as well.) If I understand the code correctly yet, the output of fillup -m is always the following: old new merged FOO=val-old FOO=val-new FOO=val-old #FOO=val-old FOO=val-new FOO=val-new FOO=val-old #FOO=val-new --- #FOO=val-old #FOO=val-new --- Q1: Why are commented variables handled at all? Q2: Is behaviour in previous table right? Q3: Behaviour explained in first example is definitely wrong, but fix fillup seems to be out of scope of 11.1, no? On my system are affected: /etc/sysconfig/SuSEfirewall2 /etc/sysconfig/network/ifcfg.template /etc/sysconfig/postfix /etc/sysconfig/autofs /etc/sysconfig/displaymanager -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.