Mailinglist Archive: opensuse-bugs (14451 mails)
| < Previous | Next > |
[Bug 440371] XIM script overwrites LANG variable incorrectly
- From: bugzilla_noreply@xxxxxxxxxx
- Date: Fri, 31 Oct 2008 07:51:44 -0600 (MDT)
- Message-id: <20081031135144.87E7D245393@xxxxxxxxxxxxxxxxxxxxxx>
https://bugzilla.novell.com/show_bug.cgi?id=440371
User jpr@xxxxxxxxxx added comment
https://bugzilla.novell.com/show_bug.cgi?id=440371#c18
--- Comment #18 from JP Rosevear <jpr@xxxxxxxxxx> 2008-10-31 07:51:43 MDT ---
(In reply to comment #12 from Mike Fabian)
It sets LANG and GDM_LANG, but more importantly in passes GDM_LANG as the
second variable to Xsession - which explicitly sets LANG. Werner is listed as
the author of this script. The comment is "Handle arguments given by
xdm/kdm/gdm".
It will be set no matter what I think, because Xsession is executed in a shell.
adduserenv runs a bash login shell, which resets LANG to default and that
value is used to replace LANG in the env (because LANG *might* have changed due
to ~/.profile, but not usually).
The Xsession script essentially does this, since $GDM_LANG is passed to it as
the second variable.
--
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
User jpr@xxxxxxxxxx added comment
https://bugzilla.novell.com/show_bug.cgi?id=440371#c18
--- Comment #18 from JP Rosevear <jpr@xxxxxxxxxx> 2008-10-31 07:51:43 MDT ---
(In reply to comment #12 from Mike Fabian)
JP> If the user selects a language in gdm different than the default,
JP> they have made a more immediate choice than ~/.profile.
OK, I see your point.
So if gdm sets LANG (by the way, does it set LANG or GDM_LANG?)
we could detect that it is already set in xim, couldn’t we?
It sets LANG and GDM_LANG, but more importantly in passes GDM_LANG as the
second variable to Xsession - which explicitly sets LANG. Werner is listed as
the author of this script. The comment is "Handle arguments given by
xdm/kdm/gdm".
I.e. in "adduserenv" in /etc/X11/xim set only these variables which
are not already set. If they are already set for whatever reason,
don’t overwrite the but use them as they are.
It will be set no matter what I think, because Xsession is executed in a shell.
adduserenv runs a bash login shell, which resets LANG to default and that
value is used to replace LANG in the env (because LANG *might* have changed due
to ~/.profile, but not usually).
Would that be OK?
(If gdm sets GDM_LANG and not LANG, we might need to copy the value of
GDM_LANG into LANG).
The Xsession script essentially does this, since $GDM_LANG is passed to it as
the second variable.
--
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
| < Previous | Next > |