https://bugzilla.novell.com/show_bug.cgi?id=432433 Summary: Bug in factory code checks for sequence-point Product: openSUSE.org Version: unspecified Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: BuildService AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: bitdealer@gmail.com QAContact: adrian@novell.com Found By: --- My Code::Blocks build for Factory fails because of the following: I: Program causes undefined operation (likely same variable used twice and post/pre incremented in the same expression). e.g. x = x++; Split it in two operations. E: codeblocks sequence-point ../../../src/include/filefilters.h: 208 See https://build.opensuse.org/package/live_build_log?arch=i586&package=CodeBlocks&project=home%3Abitshuffler&repository=openSUSE_Factory for the full log. The file in question is http://pastebin.ca/1220176 . As you can see the file isn't 208 lines long and a header file, which is why I was told that the check might report the wrong file which sounds pretty reasonable to me (I'm absolutely no C/C++ guy). Also the only option to find out what triggered that check to fail was said to be a complete code review starting with every file that includes that header file. Which isn't really an option either since the codebase is pretty big. So I would like to suggest the following: 1. If a check fails the program should cite the offending line of code so I can at least narrow it down by greping for that line. 2. If the check needs only one line as input it should rerun against the extracted / cited line of code. 3. The check should grep the source file for the offending line of code to verify its extracted filename and line number are correct. While only the first thing is relevant to me (the user) to find the offending code and fix it the other two would be great IMHO to verify the correctness of the checks since they would act like unit tests for every single failed check and thereby help you improving them. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.