https://bugzilla.novell.com/show_bug.cgi?id=262334
User federico@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=262334#c13
Federico Mena Quintero changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |federico@novell.com
Status|NEEDINFO |NEW
Info Provider|federico@novell.com |
--- Comment #13 from Federico Mena Quintero 2008-05-06 12:39:30 MST ---
Nice catch! However, this still needs to handle the case where nm_client_new()
returns NULL. This can happen if the system D-bus can't be contacted:
NMClient *
nm_client_new (void)
{
DBusGConnection *connection;
GError *err = NULL;
connection = dbus_g_bus_get (DBUS_BUS_SYSTEM, &err);
if (!connection) {
g_warning ("Couldn't connect to system bus: %s", err->message);
g_error_free (err);
return NULL;
}
return (NMClient *) g_object_new (NM_TYPE_CLIENT,
NM_OBJECT_DBUS_CONNECTION,
connection,
NM_OBJECT_DBUS_PATH, NM_DBUS_PATH,
NULL);
}
So a simple "if (!(client && nm_client_get_manager_running (...)))" should do
the trick :)
As for your Step2, it should be enough to check the status every time the menu
is opened, *but* only if NM was seen not to be active the last time we checked
(i.e. to avoid polling NM more than necessary). You can hook this in
main-menu-ui.c:present_slab_window().
--
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.