https://bugzilla.novell.com/show_bug.cgi?id=377733
User vuntz@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=377733#c5
--- Comment #5 from Vincent Untz 2008-04-30 15:11:30 MST ---
Created an attachment (id=211644)
--> (https://bugzilla.novell.com/attachment.cgi?id=211644)
First attempt to fix this
Federico, here's an attempt to fix this. Basically, gio gives us a list of icon
and right now, only the first one is used. However, the first icon is the most
specific one and generally doesn't exist in icon themes.
So we can use gtk_icon_theme_choose_icon() instead.
However, this patch is broken in a few ways:
+ it's hard-coding the icon size to 16
+ it's giving the icon path instead of the icon name to the upper layers,
which means no update when the icon theme changes
+ in an ideal world, we'd pass the array of icon names to the upper layers so
that when changing an icon theme, we look for the best icon again among all
icon names (and we might find a better one this way in the new icon theme).
First item should be easily fixable. Second item doesn't seem to be fixable
since GtkIconInfo doesn't contain the icon name :/ Third item needs quite some
work.
(btw, Federico, I'd love to get set_icon_names() functions complementing the
set_icon_name() ones)
--
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.