Mailinglist Archive: opensuse-bugs (7462 mails)
| < Previous | Next > |
[Bug 359899] New: array indices off by 1 in evdev input driver
- From: bugzilla_noreply@xxxxxxxxxx
- Date: Fri, 8 Feb 2008 05:52:37 -0700 (MST)
- Message-id: <bug-359899-21960@xxxxxxxxxxxxxxxxxxxxxxxxx/>
https://bugzilla.novell.com/show_bug.cgi?id=359899
Summary: array indices off by 1 in evdev input driver
Product: openSUSE 11.0
Version: Alpha 2
Platform: Other
OS/Version: Other
Status: NEW
Severity: Normal
Priority: P5 - None
Component: X.Org
AssignedTo: sndirsch@xxxxxxxxxx
ReportedBy: meissner@xxxxxxxxxx
QAContact: xorg-maintainer-bugs@xxxxxxxxxxxxxxxxxxxxxx
Found By: ---
Created an attachment (id=193841)
--> (https://bugzilla.novell.com/attachment.cgi?id=193841)
evdev-max-fixes.patch
gcc 4.3 warned:
evdev_axes.c: In function 'EvdevAxesRealSyn':
evdev_axes.c:170: warning: array subscript is above array bounds
evdev_axes.c:189: warning: array subscript is above array bounds
It uses axes[0x3f], which should be valid.
reviewing the code shows that XXX_MAX values are used a arraysizes, however
the arraysize should be XXX_MAX+1.
I fixed the array sizes and various checks to match reality better.
--
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Summary: array indices off by 1 in evdev input driver
Product: openSUSE 11.0
Version: Alpha 2
Platform: Other
OS/Version: Other
Status: NEW
Severity: Normal
Priority: P5 - None
Component: X.Org
AssignedTo: sndirsch@xxxxxxxxxx
ReportedBy: meissner@xxxxxxxxxx
QAContact: xorg-maintainer-bugs@xxxxxxxxxxxxxxxxxxxxxx
Found By: ---
Created an attachment (id=193841)
--> (https://bugzilla.novell.com/attachment.cgi?id=193841)
evdev-max-fixes.patch
gcc 4.3 warned:
evdev_axes.c: In function 'EvdevAxesRealSyn':
evdev_axes.c:170: warning: array subscript is above array bounds
evdev_axes.c:189: warning: array subscript is above array bounds
It uses axes[0x3f], which should be valid.
reviewing the code shows that XXX_MAX values are used a arraysizes, however
the arraysize should be XXX_MAX+1.
I fixed the array sizes and various checks to match reality better.
--
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
| < Previous | Next > |