https://bugzilla.novell.com/show_bug.cgi?id=309058
User contact@i-nz.net added comment
https://bugzilla.novell.com/show_bug.cgi?id=309058#c3
Ivan Zlatev changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |contact@i-nz.net
--- Comment #3 from Ivan Zlatev 2007-12-20 17:21:49 MST ---
* bookmarks-agent.c
Changes there look fine to me.
* main-menu-ui.c
This code is not needed. The bookmarks-agent has a gnomevfs monitor on
~/.gtk-bookmarks and it invokes update_items, which fires a property-changed
(notify::) which is handled by tile-table by reloading the table.
* directory-tile.c
It seems that by design the favorite places were meant to be handled as normal
directories (thus the directory-tile.c use), but now we want to handle them as
bookmarks. That's why we should rather have a bookmark-tile and have your code
for handling bookmark specific behavior there. This would also require some
refactoring (search-and-replace) to make user of the bookmark-tile and not a
directory-tile in the rest of the code.
Thanks for your work. Looking forward to the next iteration. :)
--
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.