https://bugzilla.novell.com/show_bug.cgi?id=340153#c1
Matt Sealey changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |matt@genesi-usa.com
--- Comment #1 from Matt Sealey 2007-11-08 04:56:36 MST ---
My comment here will be that obviously the use of existing swap files must be
able to check if the file is real or sparse, and perhaps if it is already a
valid swap file.
Actually the check should be reversed, the presence of a swap header implies
that the file is not sparse since mkswap will not operate on sparse files. This
optimizes out the need to mkswap on a potentially slow medium (even 10 or 20
seconds is a long time to hang around).
If the file is not a valid swap file then mkswap should be run, which will
confirm that it is not sparse, then it can be activated.
If the file fails mkswap then recreation of the swap file can be entertained. I
wonder about the performance of making a swap file - is "dd" the best solution?
As a preexisting tool it may be easier to entertain, but perhaps filling an
existing file or creating it through some other method (fallocate?/fopen/fwrite
loop/fclose..) is faster than starting from 0 and extending it?
--
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.