Mailinglist Archive: opensuse-bugs (9626 mails)

[bugzilla_noreply@xxxxxxxxxx]

https://bugzilla.novell.com/show_bug.cgi?id=339027

           Summary: Please, remove yast2-users RPM dependency on yast2-
                    network
           Product: openSUSE 11.0
           Version: unspecified
          Platform: Other
        OS/Version: Other
            Status: NEW
          Severity: Enhancement
          Priority: P5 - None
         Component: YaST2
        AssignedTo: jsuchome@xxxxxxxxxx
        ReportedBy: locilka@xxxxxxxxxx
         QAContact: jsrain@xxxxxxxxxx
                CC: mzugec@xxxxxxxxxx
          Found By: Development


Even if this dependency is not expressed, it really exists:

users/src/inst_auth.ycp (used in second stage)
contains:
--- cut ---
..
import "DSL";
..
if(!DSL::UsesDevice(dev))
    found = true;
..
--- cut ---

Unfortunately, DSL YCP module is part of yast2-network

However, what does really DSL::UsesDevice do?

--- cut ---
global define boolean UsesDevice(string device) {
    return size(NetworkDevices::Locate("DEVICE", device)) > 0;
}
--- cut ---

Nothing but calling NetworkDevices::Locate and NetworkDevices are part of
yast2.rpm

So I propose this patch:
--- patch ---
Index: src/inst_auth.ycp
===================================================================
--- src/inst_auth.ycp   (revision 41763)
+++ src/inst_auth.ycp   (working copy)
@@ -13,7 +13,6 @@
 textdomain "users";

 import "Directory";
-import "DSL";
 import "FileUtils";
 import "Label";
 import "Ldap";
@@ -95,7 +94,8 @@
 }
 boolean found = false || NetworkService::IsManaged ();
 maplist(string dev, net_devices, ``{
-    if(!DSL::UsesDevice(dev))
+    // if(!DSL::UsesDevice(dev))
+    if (size (NetworkDevices::Locate("DEVICE", dev)) > 0)
        found = true;
 });
 y2debug("found=%1", found);
--- patch ---

It just removes dependency on DSL.

Just a small hint. This:
    NetworkDevices::List("dsl")
should return all dsl-related devices... Maybe even better solution.

Thanks


-- 
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.