Mailinglist Archive: opensuse-bugs (15134 mails)

[bugzilla_noreply@xxxxxxxxxx]

https://bugzilla.novell.com/show_bug.cgi?id=328048#c16





--- Comment #16 from Federico Mena Quintero <federico@xxxxxxxxxx>  2007-09-26 13:16:01 MST ---
(In reply to comment #15 from Joerg Kress)
> The Patch from Federico works for me too. It will be in the update that also
> brings relief to the security guys about the /tmp issue.

Excellent, thanks!

> I look at the code flow again, but the success dialog should be shown when
> everything worked fine except there have been updates which require restart
> which will show the restart dialog.

Hmm, ok.  From looking at the code, it has this pattern:

if ("</stream>") {
  if (security_patches_done) {
    if (recommended_patches_done || !packages_included) {
      if (restart_included) {
        dialog ("you need to restart");
        gtk_main_quit ();
      } else {
        dialog ("I'm done");
        gtk_main_quit ();
      }
    } else {
      recommended_patches_done = TRUE;
      /* go back to main loop */
    }
  } else {
    if (!recommended_included && !packages_included) {
      if (restart_included) {
        dialog ("you need to restart");
        gtk_main_quit ();
      } else {
        dialog ("I'm done");
        gtk_main_quit ();
      }
    }
    /* no dialog here */
  }
}

So not all cases present a dialog.  Also, the code only looks for "<stream>"
and "</stream>", but doesn't seem to do any real parsing of the contents...
does it need to?


-- 
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.