Mailinglist Archive: opensuse-bugs (14887 mails)

[bugzilla_noreply@xxxxxxxxxx]

https://bugzilla.novell.com/show_bug.cgi?id=307754#c3





--- Comment #3 from Sascha Sommer <ssommer@xxxxxxxxxx>  2007-09-14 06:09:36 MST ---
Just a few remarks:

src/enginecontroller.cpp contains the following code snipped

    // Accept non-local files, since we can't test them for validity at this
point
    // TODO actually, only accept unconditionally http stuff
    // TODO this actually makes things like "Blarrghgjhjh:!!!" automatically
get inserted
    // into the playlist
    // TODO remove for Amarok 1.3 and above silly checks, instead check for
http type servers
    if ( !url.isLocalFile() ) return true;

so the check that would trigger the popup is never reached.
There also is the problem that it is not always possible to probe the http
streams because sometimes the streaming is only allowed to start a single time.
At least this is the case with last.fm streams.

As a workaround one could check if the url ends with .mp3 but this would only
catch only a small subset of the streams out there.


-- 
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.