Mailinglist Archive: opensuse-bugs (15113 mails)

[bugzilla_noreply@xxxxxxxxxx]

https://bugzilla.novell.com/show_bug.cgi?id=307910#c25





--- Comment #25 from JP Rosevear <jpr@xxxxxxxxxx>  2007-09-13 11:24:06 MST ---

It seems as though between gnome-keyring 0.8 and 2.19.x, gnome-keyring
changed the result code if no objects were found, in 0.8
gnome_keyring_daemon:op_find_execute we have:

if (access_requests == NULL) {
        gnome_keyring_proto_add_uint32 (result, GNOME_KEYRING_RESULT_DENIED);
} else {
        gnome_keyring_proto_add_uint32 (result, GNOME_KEYRING_RESULT_OK);
}

ie basically if no items were found (so no access requests) or no
accessible secrets were found, you'd get a DENIED back.  In 2.19.1
gkr-daemon.c:op_find we have:


/* No items given access to */
if (ctx.nfound > 0 && ctx.items == NULL) 
        gkr_buffer_add_uint32 (result, GNOME_KEYRING_RESULT_DENIED);


ie DENIED is only returned if some items were found and none could be
accessed.

NM 0.6.x releases at least assume OK == found items because of 0.8 and
previous.

Mailed upstream to see if this change was intentional or not.


-- 
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.