https://bugzilla.novell.com/show_bug.cgi?id=229210 teheo@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Info Provider|teheo@novell.com | ------- Comment #45 from teheo@novell.com 2007-06-07 00:32 MST ------- It generally looks good to me. 1. I think we can use more continue's instead of goto empty's. 2. 0xE7 should be used if /block/sdX/size is smaller than 1 << 28; otherwise, 0xEA. 0xEA is a reserved command for devices which don't support LBA48 and might cause problems. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.