Mailinglist Archive: opensuse-bugs (7993 mails)

[bugzilla_noreply@xxxxxxxxxx]

https://bugzilla.novell.com/show_bug.cgi?id=225720

           Summary: gdm-2.16.1-36: comparison with string literal
           Product: openSUSE 10.2
           Version: RC 5
          Platform: All
        OS/Version: SuSE Linux 10.1
            Status: NEW
          Severity: Normal
          Priority: P5 - None
         Component: Basesystem
        AssignedTo: bnc-team-screening@xxxxxxxxxxxxxxxxxxxxxx
        ReportedBy: dcb314@xxxxxxxxxxx
         QAContact: qa@xxxxxxx


I just tried to build the package gdm-2.16.1-36

I got the following warning message from the compiler.

gdmdynamic.c:156: warning: comparison with string literal

The source code is

    if (command == GDM_SUP_ATTACHED_SERVERS)

but

find ../BUILD/gdm-2.16.1/ -name \*.h -print | xargs fgrep
GDM_SUP_ATTACHED_SERVERS
./BUILD/gdm-2.16.1/daemon/gdm.h:#define GDM_SUP_ATTACHED_SERVERS
"ATTACHED_SERVERS" /* None */

I agree with the compiler. Maybe the programmer intended

    if ( strcmp( command, GDM_SUP_ATTACHED_SERVERS) == 0)


-- 
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.