Mailinglist Archive: opensuse-bugs (14787 mails)

[bugzilla_noreply@xxxxxxxxxx]

https://bugzilla.novell.com/show_bug.cgi?id=218742

           Summary: libata doesn't enable IRQ sharing for devices in legacy
                    mode
           Product: openSUSE 10.2
           Version: Beta 1 plus
          Platform: Other
        OS/Version: Other
            Status: NEW
          Severity: Normal
          Priority: P5 - None
         Component: Kernel
        AssignedTo: hare@xxxxxxxxxx
        ReportedBy: bwalle@xxxxxxxxxx
         QAContact: qa@xxxxxxx


If the device is in legacy mode, libata doesn't set IRQF_SHARED. The
discrimination is in drivers/ata/libata-sff.c in ata_pci_init_one() which most
drivers use in their init_one() function. Line 1055:

        if (legacy_mode) {
                probe_ent = ata_pci_init_legacy_port(pdev, port, legacy_mode);
        } else {
                if (n_ports == 2)
                        probe_ent = ata_pci_init_native_mode(pdev, port,
ATA_PORT_PRIMARY | ATA_PORT_SECONDARY);
                else
                        probe_ent = ata_pci_init_native_mode(pdev, port,
ATA_PORT_PRIMARY);
        }

While ata_pci_init_native_mode() sets the flag for IRQ sharing,
ata_pci_init_legacy_port() doesn't.


-- 
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.