Mailinglist Archive: opensuse-boosters (69 mails)

< Previous Next >
[opensuse-boosters] Retrospectiva
  • From: Michal Hrusecky <mhrusecky@xxxxxxx>
  • Date: Sat, 19 Dec 2009 13:13:31 +0100
  • Message-id: <20091219121331.GA5318@xxxxxxxxxxxxxxxxxxxxxxxxxx>
Hi,

as we discussed on the meeting, here are the patches for retrospectiva.
Some brief description:

0001-Showing-goals-in-stories-page-in-agile_pm.patch

Shows goal in stories list. Patch sent upstream:
http://retrospectiva.org/tickets/741

0002-Showing-stories-in-goals-listing-in-agile_pm.patch

Shows stories in goals list. Patch sent upstream:
http://retrospectiva.org/tickets/742

0003-Stories-follow-goal-to-the-new-sprint-in-agile_pm.patch

Unfinished stories will be moved to the new sprint when goal
they belong to is moved. Patch sent upstream:
http://retrospectiva.org/tickets/743

0004-Disabling-animation.patch

Disabling animation on goals page that some of you complained
about. Not really sure whether we want this, maybe we should
vote. Certainly wouldn't go to the upstream.

--
Michal HRUSECKY SUSE LINUX, s.r.o
openSUSE Boosters Team Lihovarska 1060/12
PGP 0xFED656F6 19000 Praha 9
mhrusecky[at]suse.cz Czech Republic
http://michal.hrusecky.net http://www.suse.cz
From 5d517f7c49273a0fb0660b741b9bdb90e9cb797e Mon Sep 17 00:00:00 2001
From: Michal Hrusecky <Michal@xxxxxxxxxxxx>
Date: Fri, 18 Dec 2009 17:56:16 +0100
Subject: [PATCH 1/4] Showing goals in stories page in agile_pm

Stories can belong to the goal but this relation is nowhere displayed.
With this commit goal is shown in stories listing.
---
extensions/agile_pm/views/stories/_story.html.erb | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/extensions/agile_pm/views/stories/_story.html.erb
b/extensions/agile_pm/views/stories/_story.html.erb
index 9c3a264..8369f77 100644
--- a/extensions/agile_pm/views/stories/_story.html.erb
+++ b/extensions/agile_pm/views/stories/_story.html.erb
@@ -15,6 +15,11 @@
:method => :get %>
</div>
<div class="small"><%= "S#{story.id} &ndash; " + story_status(story)
%></div>
+ <% if story.goal -%>
+ <div class="small">Goal:
+ <%= h(truncate(story.goal.title, :length => 50)) %>
+ </div>
+ <% end -%>
</td>

<td class="actions righted span-4">
--
1.6.6.rc3

From c7f0bfb468fe76e05df5ae0229f9ec7945bf0a19 Mon Sep 17 00:00:00 2001
From: Michal Hrusecky <Michal@xxxxxxxxxxxx>
Date: Fri, 18 Dec 2009 18:07:41 +0100
Subject: [PATCH 2/4] Showing stories in goals listing in agile_pm

Goals can have many stories. With this patch list of all related stories
is displayed in goals view.
---
extensions/agile_pm/models/goal.rb | 1 +
.../agile_pm/public/stylesheets/agile_pm.css | 2 ++
extensions/agile_pm/views/goals/_goal.html.erb | 15 +++++++++++++++
3 files changed, 18 insertions(+), 0 deletions(-)

diff --git a/extensions/agile_pm/models/goal.rb
b/extensions/agile_pm/models/goal.rb
index 14666b1..8087713 100644
--- a/extensions/agile_pm/models/goal.rb
+++ b/extensions/agile_pm/models/goal.rb
@@ -5,6 +5,7 @@
class Goal < ActiveRecord::Base
belongs_to :milestone
belongs_to :sprint
+ has_many :story
belongs_to :requester, :class_name => 'User'

Priority = Struct.new(:id, :name)
diff --git a/extensions/agile_pm/public/stylesheets/agile_pm.css
b/extensions/agile_pm/public/stylesheets/agile_pm.css
index d2363f8..72b07d7 100644
--- a/extensions/agile_pm/public/stylesheets/agile_pm.css
+++ b/extensions/agile_pm/public/stylesheets/agile_pm.css
@@ -10,6 +10,8 @@
.agile-pm table.sprint thead tr th { border-top:1px solid #fff; }
.agile-pm table.sprint tbody tr td { border-top:1px solid #bbb; }
.agile-pm table.sprint table.goals tbody td { border-top:0;
vertical-align:middle; }
+.agile-pm table.sprint .completed { font-weight: normal; font-style: italic;
}
+.agile-pm table.sprint .active { font-weight: bold; font-style: normal;
}

.agile-pm .apm-nav-link { padding: 1px 4px; border:1px solid #ccc;
font-weight: bold; }
.agile-pm a.apm-nav-link { border-color:#ddd; }
diff --git a/extensions/agile_pm/views/goals/_goal.html.erb
b/extensions/agile_pm/views/goals/_goal.html.erb
index 2bfd6a6..796f94c 100644
--- a/extensions/agile_pm/views/goals/_goal.html.erb
+++ b/extensions/agile_pm/views/goals/_goal.html.erb
@@ -4,6 +4,21 @@
<%= link_to_remote h(truncate(goal.title, :length => 50)),
:url => goal_path(goal, :format => :js),
:method => :get %>
+ <div>
+ <ul>
+ <% goal.story.each do |story| -%>
+ <li>
+ <% if story.completed_at; then -%>
+ <div class="completed">
+ <% else -%>
+ <div class="active">
+ <% end -%>
+ <%= story.title %>
+ </div>
+ </li>
+ <% end -%>
+ </ul>
+ </div>
</td>
<td class="righted span-1 strong">
<%= x_image_tag "priority-#{goal.priority_id}.gif", :alt =>
h(goal.priority.name), :title => h(goal.priority.name) %>
--
1.6.6.rc3

From a206a850ffdeda7e740dba54e45317ab094c7e03 Mon Sep 17 00:00:00 2001
From: Michal Hrusecky <Michal@xxxxxxxxxxxx>
Date: Sat, 19 Dec 2009 13:00:49 +0100
Subject: [PATCH 3/4] Stories follow goal to the new sprint in agile_pm

Goal can be edited and moved to the new sprint when it wasn't
accomplished in previous one. With this patch all unfinished stories
belonging to this goal will follow the goal to the new sprint.
---
extensions/agile_pm/lib/goals_controller.rb | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/extensions/agile_pm/lib/goals_controller.rb
b/extensions/agile_pm/lib/goals_controller.rb
index 75ccc19..49936dd 100644
--- a/extensions/agile_pm/lib/goals_controller.rb
+++ b/extensions/agile_pm/lib/goals_controller.rb
@@ -84,6 +84,15 @@ class GoalsController < ProjectAreaController
respond_to do |format|
if @goal.update_attributes(params[:goal])
flash[:notice] = _('Goal was successfully updated.')
+ sprint_id = params[:goal][:sprint_id] || 0
+ if sprint_id.to_i > 0; then
+ @goal.story.each do |story|
+ if ! story.completed_at; then
+ story.sprint_id = sprint_id
+ story.save
+ end
+ end
+ end
format.html { redirect_to sprint_location }
format.xml { head :ok }
else
--
1.6.6.rc3

From fe52e455b63aa36808c53b2c779ee0a8bc736ce9 Mon Sep 17 00:00:00 2001
From: Michal Hrusecky <Michal@xxxxxxxxxxxx>
Date: Sat, 19 Dec 2009 13:03:18 +0100
Subject: [PATCH 4/4] Disabling animation

Quite some of us complained about animation in goals view. This disables
it.
---
extensions/agile_pm/views/goals/_chart.html.erb | 11 -----------
1 files changed, 0 insertions(+), 11 deletions(-)

diff --git a/extensions/agile_pm/views/goals/_chart.html.erb
b/extensions/agile_pm/views/goals/_chart.html.erb
index d48b35c..e69de29 100644
--- a/extensions/agile_pm/views/goals/_chart.html.erb
+++ b/extensions/agile_pm/views/goals/_chart.html.erb
@@ -1,11 +0,0 @@
-<tr><td colspan="4">
- <div id="<%= sprint_dom_id %>_chart_swf"></div>
- <% javascript_tag do -%>
- swfobject.embedSWF("<%= x_image_path('open-flash-chart.swf') %>", "<%=
sprint_dom_id %>_chart_swf", "600", "200", "9.0.0","<%=
x_image_path('expressInstall.swf') %>", false,
- {
- 'flashvars': "<%= {'data-file' => sprint_path(sprint, :format =>
:json)}.to_query %>"
- }, {
- 'class': "sprint-chart"
- });
- <% end -%>
-</td></tr>
--
1.6.6.rc3

< Previous Next >
Follow Ups