On Thursday 06 January 2005 02:40, Andi Kleen wrote:
This bad hack "fixes" my problem, but it's not a real solution. It is
Given the typo I'm surprised it still works at all.
Well, it works because "variable = 0x10000" is always true, so it always ignores the reported residue from the device, which is wrong, anyway :-(. I expected GCC to give me a warning, so what happend to -Wall on kernel compiles?
However I would suspect a better fix would be to limit the device to smaller transfer sizes. You can do that by lowering max_sectors in sysfs or adding an entry in drivers/usb/storage/scsiglue.c:slave_configure() There is already a similar workaround for another device there.
Yes, that was the place I wanted to know (see attachment, this time with real == comparisons ;-).
That would probably be the right workaround. Given that thre is an easy workaround I don't think we'll take such a patch for 9.2, but if it gets into mainline the next release will likely have it.
Ok. -- Bernd Paysan "If you want it done right, you have to do it yourself" http://www.jwdt.com/~paysan/