Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 106c8a4864ab084d8c859b375291cfa0346e5966
https://github.com/openSUSE/open-build-service/commit/106c8a4864ab084d8c859b...
Author: Björn Geuken
Date: 2017-03-28 (Tue, 28 Mar 2017)
Changed paths:
M src/api/app/models/project.rb
Log Message:
-----------
[api] Refactor Project#check_access?
Remove condition that always evaluate to true since grouprels is always
an array.
Commit: 135ed0be47062a598ebe84b8758db1e053fccd34
https://github.com/openSUSE/open-build-service/commit/135ed0be47062a598ebe84...
Author: Björn Geuken
Date: 2017-03-28 (Tue, 28 Mar 2017)
Changed paths:
M src/api/app/models/package.rb
M src/api/app/models/project.rb
Log Message:
-----------
[api] Remove default parameter value from check_access?
It didn't make sense to set the default to self, since check_access?
is a class method.
Commit: 8889f8aa1bb365f6259daae0557412a7c0808f4d
https://github.com/openSUSE/open-build-service/commit/8889f8aa1bb365f6259daa...
Author: Björn Geuken
Date: 2017-03-28 (Tue, 28 Mar 2017)
Changed paths:
M src/api/app/models/project.rb
Log Message:
-----------
[api] Fix using nonexistent variable: group -> grouprel
Commit: 804f0dc88912da7c591edc428b2b40cc12adbb04
https://github.com/openSUSE/open-build-service/commit/804f0dc88912da7c591edc...
Author: Björn Geuken
Date: 2017-03-28 (Tue, 28 Mar 2017)
Changed paths:
M src/api/app/models/project.rb
Log Message:
-----------
[api] Refactor querying groups in Project#check_access?
* Drop temporary variable and array conversion
* Include groups directly when querying group relationships.
When passing a group id to is_in_group?, the method is fetching the
group from DB. We can avoid this by passing the object directly.
Commit: ec646ab9e015e493e822d5b8b27b37982467632f
https://github.com/openSUSE/open-build-service/commit/ec646ab9e015e493e822d5...
Author: Björn Geuken
Date: 2017-03-28 (Tue, 28 Mar 2017)
Changed paths:
M src/api/app/models/project.rb
Log Message:
-----------
[api] Drop conditional check when iterating through group relations
Since we iterate through group relations, we already know that each item
has a group associated. No need to check this again.
Commit: 321a949efbeb0378aec7da4e479bb77c08678cd2
https://github.com/openSUSE/open-build-service/commit/321a949efbeb0378aec7da...
Author: Björn Geuken
Date: 2017-03-28 (Tue, 28 Mar 2017)
Changed paths:
M src/api/app/models/project.rb
Log Message:
-----------
[api] Refactor check if User.current belongs to group
Commit: 7d998fb5faf8c5291d5ba37e0d1925f8e33c016b
https://github.com/openSUSE/open-build-service/commit/7d998fb5faf8c5291d5ba3...
Author: Björn Geuken
Date: 2017-03-28 (Tue, 28 Mar 2017)
Changed paths:
M src/api/app/models/user_ldap_strategy.rb
Log Message:
-----------
[api] Refactor UserLdapStrategy#user_in_group_ldap?
Commit: efa3b95d2f7318c98e188cb70fe7e00bd0895160
https://github.com/openSUSE/open-build-service/commit/efa3b95d2f7318c98e188c...
Author: Björn Geuken
Date: 2017-03-28 (Tue, 28 Mar 2017)
Changed paths:
M src/api/app/models/package.rb
M src/api/app/models/project.rb
Log Message:
-----------
[api] Update variable naming of check_access? methods
Commit: 4e493b1f61e09a6adc4b7d3a2fe1cb840e8aaaff
https://github.com/openSUSE/open-build-service/commit/4e493b1f61e09a6adc4b7d...
Author: Henne Vogelsang
Date: 2017-03-28 (Tue, 28 Mar 2017)
Changed paths:
M src/api/app/models/package.rb
M src/api/app/models/project.rb
M src/api/app/models/user_ldap_strategy.rb
Log Message:
-----------
Merge pull request #2911 from bgeuken/cleanup_check_access
Cleanup check access
Compare: https://github.com/openSUSE/open-build-service/compare/644281ffc756...4e493b...
