Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 9662a9643e503fe5431d3bd94ec2234f016f4ef5
https://github.com/openSUSE/open-build-service/commit/9662a9643e503fe5431d3b...
Author: Ana María Martínez Gómez
Date: 2017-03-17 (Fri, 17 Mar 2017)
Changed paths:
M src/api/.rubocop.yml
M src/api/.rubocop_todo.yml
Log Message:
-----------
[ci] Enable Rails/SkipsModelValidations cop
Commit: 9e048bf29f1934cc971d24aa6e1f49a8ac5efdac
https://github.com/openSUSE/open-build-service/commit/9e048bf29f1934cc971d24...
Author: Ana María Martínez Gómez
Date: 2017-03-17 (Fri, 17 Mar 2017)
Changed paths:
M src/api/.rubocop.yml
M src/api/app/models/bs_request.rb
M src/api/app/models/package_issue.rb
M src/api/app/models/updateinfo_counter.rb
M src/api/spec/controllers/webui/user_controller_spec.rb
M src/api/test/unit/event_mailer_test.rb
Log Message:
-----------
[ci] Solve Rails/SkipsModelValidations offenses
There is not autocorrect for this cop.
Solve all the offenses, except the `update_column` in `package#update_activity`.
Solving this offenses is tricky, so I'll include it in a separated commit.
Commit: 15a916845eb547691b5123e51a07a5d25c2cfc2b
https://github.com/openSUSE/open-build-service/commit/15a916845eb547691b5123...
Author: Ana María Martínez Gómez
Date: 2017-03-17 (Fri, 17 Mar 2017)
Changed paths:
M src/api/app/models/package.rb
Log Message:
-----------
[api][ci] Validate updating package activity
`package#update_activity` was called from both a `before_update` and a method.
An attribute was updated inside this method and as this was call from a
`before update` could not be updated because if not it would enter in an
infinite loop. So `update_column`, which skip the validations, was used for
that. But then when being called from the method the validations were skip.
Now, instead of calling it from the mehotd we call `update` there, which calls
the `before_update` callback and run all the validations as well.
Commit: af673266140d4bc029e42a83f90ca86d14f65d17
https://github.com/openSUSE/open-build-service/commit/af673266140d4bc029e42a...
Author: Ana María Martínez Gómez
Date: 2017-03-17 (Fri, 17 Mar 2017)
Changed paths:
M src/api/app/models/package.rb
Log Message:
-----------
[api] Move package#_add_chanel to private section
Commit: df9d938492b6f824a435c7c165b7975cce7d11b1
https://github.com/openSUSE/open-build-service/commit/df9d938492b6f824a435c7...
Author: Ana María Martínez Gómez
Date: 2017-03-17 (Fri, 17 Mar 2017)
Changed paths:
M src/api/app/models/package.rb
M src/api/test/functional/statistics_controller_test.rb
M src/api/test/unit/package_test.rb
Log Message:
-----------
[ci] Fix broken tests
Broken by the small changes in update_activity.
Commit: d561995b537abc1e9bce2480fc9df6ce6243c820
https://github.com/openSUSE/open-build-service/commit/d561995b537abc1e9bce24...
Author: Ana María Martínez Gómez
Date: 2017-03-17 (Fri, 17 Mar 2017)
Changed paths:
M src/api/app/models/package.rb
Log Message:
-----------
[ci] Comments for things only needed in the tests
Add comments of things that things that can be improved when we remove the old
test suite.
Commit: 6389055e818a7c693fb9c7142398f0b1ef30a129
https://github.com/openSUSE/open-build-service/commit/6389055e818a7c693fb9c7...
Author: Ana María Martínez Gómez
Date: 2017-03-17 (Fri, 17 Mar 2017)
Changed paths:
M src/api/app/models/package.rb
M src/api/app/views/statistics/most_active_packages.xml.builder
A src/api/db/migrate/20170316090223_remove_update_counter_from_package.rb
M src/api/db/structure.sql
M src/api/test/fixtures/packages.yml
M src/api/test/functional/statistics_controller_test.rb
M src/api/test/unit/package_test.rb
Log Message:
-----------
[api] No more beauty
Remove `update_counter` attribute from `Package` as it is not used, and before
62337a915756e284e75873ad936ec32e30d84ee2 it was not even always update.
Commit: 5fd14e18ea409e31f034f0047dafc71b179d588a
https://github.com/openSUSE/open-build-service/commit/5fd14e18ea409e31f034f0...
Author: Ana María Martínez Gómez
Date: 2017-03-20 (Mon, 20 Mar 2017)
Changed paths:
M src/api/.rubocop.yml
M src/api/.rubocop_todo.yml
M src/api/app/models/bs_request.rb
M src/api/app/models/package.rb
M src/api/app/models/package_issue.rb
M src/api/app/models/updateinfo_counter.rb
M src/api/app/views/statistics/most_active_packages.xml.builder
A src/api/db/migrate/20170316090223_remove_update_counter_from_package.rb
M src/api/db/structure.sql
M src/api/spec/controllers/webui/user_controller_spec.rb
M src/api/test/fixtures/packages.yml
M src/api/test/functional/statistics_controller_test.rb
M src/api/test/unit/event_mailer_test.rb
M src/api/test/unit/package_test.rb
Log Message:
-----------
Merge pull request #2777 from Ana06/skip_validation_cop
Enable Rails/SkipsModelValidations cop
Compare: https://github.com/openSUSE/open-build-service/compare/ca026f81b207...5fd14e...
