Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: aacdaf4926018d148b541fee045a0fa8e4e00d01
https://github.com/openSUSE/open-build-service/commit/aacdaf4926018d148b541f...
Author: Björn Geuken
Date: 2017-03-03 (Fri, 03 Mar 2017)
Changed paths:
M src/api/app/policies/group_policy.rb
Log Message:
-----------
[webui] Refactor GroupPolicy#update?
* Re-aranging method code to shorten it (= easier to read)
* Remove comments of self-explantory code
* User exists?, which happens on SQL level, instead of present?
Commit: eefe935a824700fcc64a01d1b0282c8489fa5d21
https://github.com/openSUSE/open-build-service/commit/eefe935a824700fcc64a01...
Author: Björn Geuken
Date: 2017-03-03 (Fri, 03 Mar 2017)
Changed paths:
M src/api/app/policies/attrib_policy.rb
Log Message:
-----------
[webui] Remove unnecessary nil checks in AttribPolicy#create?
Commit: ae0e575132a3d0b53ea9699a6f9ead58dbdcc1b8
https://github.com/openSUSE/open-build-service/commit/ae0e575132a3d0b53ea969...
Author: Björn Geuken
Date: 2017-03-03 (Fri, 03 Mar 2017)
Changed paths:
M src/api/app/policies/attrib_policy.rb
Log Message:
-----------
[webui] Refactor AttribPolicy#create?, part I
* Move type and namespace permission checks into seperate methods. That
should make the main policy smaller and more readable
* Added comments to newly created methods
* Uses any? iterator instead of each to reduce complexity
Commit: e4565c28d04e1c9f581ce170bba1d4ffe86a35bf
https://github.com/openSUSE/open-build-service/commit/e4565c28d04e1c9f581ce1...
Author: Björn Geuken
Date: 2017-03-06 (Mon, 06 Mar 2017)
Changed paths:
M src/api/app/policies/attrib_policy.rb
Log Message:
-----------
[webui] Refactor AttribPolicy#create?, part II
* Merged namespace and type permission methods to generic
permissions_for_modifiables? method
* Moved collecting modifiables for permission check into seperate method
Commit: 7182de11fc00256310bc5a10492406f5ff994cb3
https://github.com/openSUSE/open-build-service/commit/7182de11fc00256310bc5a...
Author: Björn Geuken
Date: 2017-03-06 (Mon, 06 Mar 2017)
Changed paths:
M src/api/app/controllers/webui/request_controller.rb
M src/api/app/models/package.rb
M src/api/app/models/project.rb
M src/api/app/policies/attrib_policy.rb
Log Message:
-----------
[api] can_be_modified_by? method for Package and Project model
This commit adds a can_be_modified_by? method to Package and Project model, which
checks if a user has direct access rights for a package / project.
This allows us to simplify some code, since we don't have to check what
object we are working with.
Commit: fc126da42483a23fe3d8ff4cc5926aa65256061e
https://github.com/openSUSE/open-build-service/commit/fc126da42483a23fe3d8ff...
Author: Björn Geuken
Date: 2017-03-06 (Mon, 06 Mar 2017)
Changed paths:
M src/api/app/policies/attrib_policy.rb
Log Message:
-----------
[webui] Turn around condition in AttribPolicy#create?
Since we fallback to the container permission check anyway, we can also
test this first and only do the other permission checks if needed.
Commit: 290faf7535fb1f080ff8179047c1ce273cf9133c
https://github.com/openSUSE/open-build-service/commit/290faf7535fb1f080ff817...
Author: Björn Geuken
Date: 2017-03-06 (Mon, 06 Mar 2017)
Changed paths:
M src/api/app/policies/attrib_policy.rb
Log Message:
-----------
[webui] Refactor modifiables method
Commit: 539a26ecb4f567b2179428d6b9a4bec019999f93
https://github.com/openSUSE/open-build-service/commit/539a26ecb4f567b2179428...
Author: Björn Geuken
Date: 2017-03-06 (Mon, 06 Mar 2017)
Changed paths:
M src/api/app/controllers/webui/request_controller.rb
M src/api/app/models/package.rb
M src/api/app/models/project.rb
M src/api/app/policies/attrib_policy.rb
M src/api/app/policies/group_policy.rb
Log Message:
-----------
Merge pull request #2751 from bgeuken/cleanup_pundit_policies
Cleanup pundit policies
Compare: https://github.com/openSUSE/open-build-service/compare/4b696629c5cf...539a26...
