Branch: refs/heads/ruboloop
Home: https://github.com/openSUSE/open-build-service
Commit: bb03a9ef0733e1588bfc75c008a8dcfc80a55cc0
https://github.com/openSUSE/open-build-service/commit/bb03a9ef0733e1588bfc75...
Author: Björn Geuken
Date: 2017-03-02 (Thu, 02 Mar 2017)
Changed paths:
M src/api/app/models/issue_tracker.rb
Log Message:
-----------
[api] DRY code by splitting out redirect loop
The issue tracker fetches data from a remote http location via GET. In case
that the server responds with a redirect location we want to follow this route.
Since the code for that is always the same, we can move it into a seperate
method to avoid duplication.
Commit: af419d4649a7d9919215a3b7cc5ce81c31bf6af4
https://github.com/openSUSE/open-build-service/commit/af419d4649a7d9919215a3...
Author: Björn Geuken
Date: 2017-03-02 (Thu, 02 Mar 2017)
Changed paths:
M src/api/.rubocop.yml
M src/api/.rubocop_todo.yml
M src/api/app/models/issue_tracker.rb
M src/api/app/models/update_notification_events.rb
Log Message:
-----------
[api] Apply rubocop rule 'Lint/Loop'
"Lint/Loop: Use Kernel#loop with break rather than begin/end/until(or while)."
Commit: 3037a07ba27cb0593633c203cfc2951c09737e22
https://github.com/openSUSE/open-build-service/commit/3037a07ba27cb0593633c2...
Author: Björn Geuken
Date: 2017-03-02 (Thu, 02 Mar 2017)
Changed paths:
M src/api/app/models/issue_tracker.rb
Log Message:
-----------
[api] Cleanup app/models/issue_tracker.rb
* Fix rubocop offense: "Rails/Date: Do not use to_time on Date objects,
because they know nothing about the time zone in use."
* Remove outcommented code
* Use selfexplaining variable names, eg. u -> user
* Cleanup conditions
Compare: https://github.com/openSUSE/open-build-service/compare/bb03a9ef0733^...3037a07ba27c
