Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 3add9e1a5753d60516a5c0e9c11a61975c55f599
https://github.com/openSUSE/open-build-service/commit/3add9e1a5753d60516a5c0...
Author: Stephan Kulow
Date: 2014-01-29 (Wed, 29 Jan 2014)
Changed paths:
M src/api/app/controllers/request_controller.rb
M src/api/app/models/bs_request_action.rb
M src/api/app/models/package.rb
M src/api/test/functional/request_controller_test.rb
M src/api/test/functional/webui/request_controller_test.rb
Log Message:
-----------
[api] allow to accept reviews for delete requests
wrote a test case to highlight issue #550 and fix it with yet another
attack of the spaghetti code monster
Commit: dc11f7fd1895c9a3dee77dcf54a18fa292f78286
https://github.com/openSUSE/open-build-service/commit/dc11f7fd1895c9a3dee77d...
Author: Stephan Kulow
Date: 2014-01-29 (Wed, 29 Jan 2014)
Changed paths:
M src/api/app/controllers/request_controller.rb
M src/api/app/models/bs_request.rb
M src/api/app/models/bs_request_action.rb
M src/api/app/models/bs_request_action_delete.rb
M src/api/app/models/bs_request_action_group.rb
A src/api/app/models/bs_request_permission_check.rb
M src/api/lib/api_exception.rb
M src/api/test/functional/request_controller_test.rb
M src/api/test/unit/code_quality_test.rb
Log Message:
-----------
[api] refactor the whole changestate permission check
This whole logic if a request can change state is worth an extra file, it's
almost 300 lines of code
Commit: 5a9a7daa608db373491ab5886bc563b8d3045694
https://github.com/openSUSE/open-build-service/commit/5a9a7daa608db373491ab5...
Author: Stephan Kulow
Date: 2014-01-29 (Wed, 29 Jan 2014)
Changed paths:
M src/api/app/models/bs_request_permission_check.rb
M src/api/test/unit/code_quality_test.rb
Log Message:
-----------
[api] split the changestate check
the various action types require different checks so they can also have
different functions
Compare: https://github.com/openSUSE/open-build-service/compare/8c53bce40f11...5a9a7d...
