[zypp-devel] Re: [zypp-commit] r11775 - in /trunk/sat-solver: src/knownid.h tools/repo_products.c
Hi, On Fri, 21 Nov 2008, dmacvicar@svn.opensuse.org wrote:
Log: go away repokey
--- trunk/sat-solver/src/knownid.h (original) +++ trunk/sat-solver/src/knownid.h Fri Nov 21 17:12:29 2008 @@ -166,8 +166,6 @@ KNOWNID(PRODUCT_URL_TYPE, "product:url:type"), KNOWNID(PRODUCT_FLAGS, "product:flags"), KNOWNID(PRODUCT_PRODUCTLINE, "product:productline"), -/* this has to be obsoleted */ -KNOWNID(PRODUCT_UPDATEREPOKEY, "product:updaterepokey"), KNOWNID(PRODUCT_REGISTER_TARGET, "product:regtarget"), KNOWNID(PRODUCT_REGISTER_RELEASE, "product:regrelease"),
This is for example one instance of a binary incompatible change. If we want to be serious about stability in the future we need to watch out for these things. (In this case the problem is, that this all defines an enum, hence numbers with a name and an association between those numbers and the strings. The change above assigns to all strings behind the removed item a number one less than before. So binary programs that e.g. used PRODUCT_REGISTER_TARGET to lookup attributes will now look for string "product:regrelease") This doesn't yet matter with just the static library, when the applications are also recompiled with the new header. Ciao, Michael. -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
participants (1)
-
Michael Matz