[zypp-devel] question
question :-) MediaHandler has virtuals, and provide default implementation. All concrete handlers override them, foo, only to call MediaHandler::foo() in the reimplementation. What is the purpose of this? (at least, makes really hard and boring to do any refactoring changing method signatures). Duncan -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Duncan Mac-Vicar P. wrote:
question :-)
MediaHandler has virtuals, and provide default implementation.
All concrete handlers override them, foo, only to call MediaHandler::foo() in the reimplementation. What is the purpose of this?
That's a question for Marius, maybe he had some reason. But i would guess that this is to make the ABI more stable. If you had to change the default behavior once the API was published, you would have to break the ABI by adding new function that overrides another. - -- cheers, jano Ján Kupec YaST team - ---------------------------------------------------------(PGP)--- Key ID: 637EE901 Fingerprint: 93B9 C79B 2D20 51C3 800B E09B 8048 46A6 637E E901 - ---------------------------------------------------------(IRC)--- Server: irc.freenode.net Nick: jniq Channels: #zypp #yast #suse #susecz - ---------------------------------------------------------(EOF)--- -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkmkR+AACgkQgEhGpmN+6QEPkgCfUJq4Ilu1D0/vdQ/Qk4RLbY5d qnoAn1qnEdeoMWlrzgJUvrkUPPhD00bW =Kx/4 -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
On Tuesday 24 February 2009 20:17:53 Jan Kupec wrote:
Duncan Mac-Vicar P. wrote:
question :-)
MediaHandler has virtuals, and provide default implementation.
All concrete handlers override them, foo, only to call MediaHandler::foo() in the reimplementation. What is the purpose of this?
That's a question for Marius, maybe he had some reason. But i would
Marius is innocent. Those are basically the old yast2-packagemanager media handler. -- cu, Michael Andres +------------------------------------------------------------------+ Key fingerprint = 2DFA 5D73 18B1 E7EF A862 27AC 3FB8 9E3A 27C6 B0E4 +------------------------------------------------------------------+ Michael Andres YaST Development ma@novell.com SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg) Maxfeldstrasse 5, D-90409 Nuernberg, Germany, ++49 (0)911 - 740 53-0 +------------------------------------------------------------------+ -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
participants (3)
-
Duncan Mac-Vicar P.
-
Jan Kupec
-
Michael Andres