[zypp-devel] [Patch] zypp/media/MediaAria2c.cc: better aria2c options
Hi, the attached is a patch for Factory, which changes the aria2c call to append two commandline switches. One of them will save a massive amount of HEAD requests on us, the other one will adjust the number of parallel download connections to something more harmless (2 instead of 5). The latter should actually be made configurable, though. Adding the latter switch probably means that it isn't possible anymore to override the setting with ~/.aria2/aria2.conf, but we need a good default to start with, and can't expect anyone to have ~/.aria2/aria2.conf either. Settings like this should go to /etc/zypp/* I think. It is particularly useful to configure a log file for aria2c for example (log=/var/log/aria2.log). Peter -- "WARNING: This bug is visible to non-employees. Please be respectful!" SUSE LINUX Products GmbH Research & Development
Peter Poeml wrote:
Hi,
the attached is a patch for Factory, which changes the aria2c call to append two commandline switches. One of them will save a massive amount of HEAD requests on us, the other one will adjust the number of parallel download connections to something more harmless (2 instead of 5). The latter should actually be made configurable, though.
Adding the latter switch probably means that it isn't possible anymore to override the setting with ~/.aria2/aria2.conf, but we need a good default to start with, and can't expect anyone to have ~/.aria2/aria2.conf either. Settings like this should go to /etc/zypp/* I think. It is particularly useful to configure a log file for aria2c for example (log=/var/log/aria2.log).
Peter
that code does not exist in my branch, as the aria command is now in a abstract class, but I will port it. thanks! -- Duncan Mac-Vicar P. - Engineering Manager, YaST SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg) -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
Hi Duncan, On Tue, Feb 17, 2009 at 06:25:56PM +0100, Duncan Mac-Vicar Prett wrote:
Peter Poeml wrote:
Hi,
the attached is a patch for Factory, which changes the aria2c call to append two commandline switches. One of them will save a massive amount of HEAD requests on us, the other one will adjust the number of parallel download connections to something more harmless (2 instead of 5). The latter should actually be made configurable, though.
Adding the latter switch probably means that it isn't possible anymore to override the setting with ~/.aria2/aria2.conf, but we need a good default to start with, and can't expect anyone to have ~/.aria2/aria2.conf either. Settings like this should go to /etc/zypp/* I think. It is particularly useful to configure a log file for aria2c for example (log=/var/log/aria2.log).
Peter
that code does not exist in my branch, as the aria command is now in a abstract class, but I will port it. thanks!
It's easy enough I guess ;-) Thanks, Peter -- Contact: admin@opensuse.org (a.k.a. ftpadmin@suse.com) #opensuse-mirrors on freenode.net Info: http://en.opensuse.org/Mirror_Infrastructure SUSE LINUX Products GmbH Research & Development
Peter Poeml wrote:
Adding the latter switch probably means that it isn't possible anymore to override the setting with ~/.aria2/aria2.conf, but we need a good default to start with, and can't expect anyone to have ~/.aria2/aria2.conf either. Settings like this should go to /etc/zypp/* I think. It is particularly useful to configure a log file for aria2c for example (log=/var/log/aria2.log).
Peter
While adding these options to my local branch, I also implemented zypp.conf options for min speed limits (to fix bnc#408816), max speed limits, and made the concurrent connections configurable. I haven't commited this yet though. The part that was problematic was the --use-head, as it requires aria2c from OBS (1.2.0), while openSUSE 11.1 has 0.16 and Factory 1.15. Peter, can you submit the new one to Factory? Duncan -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
Hi Duncan, On Sat, Feb 21, 2009 at 03:27:45PM +0100, Duncan Mac-Vicar P. wrote:
Peter Poeml wrote:
Adding the latter switch probably means that it isn't possible anymore to override the setting with ~/.aria2/aria2.conf, but we need a good default to start with, and can't expect anyone to have ~/.aria2/aria2.conf either. Settings like this should go to /etc/zypp/* I think. It is particularly useful to configure a log file for aria2c for example (log=/var/log/aria2.log).
Peter
While adding these options to my local branch, I also implemented zypp.conf options for min speed limits (to fix bnc#408816), max speed limits, and made the concurrent connections configurable. I haven't commited this yet though.
That's really cool!
The part that was problematic was the --use-head, as it requires aria2c from OBS (1.2.0), while openSUSE 11.1 has 0.16 and Factory 1.15. Peter, can you submit the new one to Factory?
Factory actually already has 1.2.0. Peter -- Contact: admin@opensuse.org (a.k.a. ftpadmin@suse.com) #opensuse-mirrors on freenode.net Info: http://en.opensuse.org/Mirror_Infrastructure SUSE LINUX Products GmbH Research & Development -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
Peter Poeml wrote:
Factory actually already has 1.2.0.
Peter
You sure? http://software.opensuse.org/search?baseproject=openSUSE%3AFactory&p=1&q=aria2 -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
On Sat, Feb 21, 2009 at 05:01:10PM +0100, Duncan Mac-Vicar P. wrote:
Peter Poeml wrote:
Factory actually already has 1.2.0.
Peter
You sure?
Yes, I know the submit request was accepted, and i looked on download.opensuse.org/factory and definitely saw it there, so it also built successfully.
http://software.opensuse.org/search?baseproject=openSUSE%3AFactory&p=1&q=aria2
Hm. Scroll down ;) Peter -- Contact: admin@opensuse.org (a.k.a. ftpadmin@suse.com) #opensuse-mirrors on freenode.net Info: http://en.opensuse.org/Mirror_Infrastructure SUSE LINUX Products GmbH Research & Development -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
On Sat, Feb 21, 2009 at 05:01:10PM +0100, Duncan Mac-Vicar P. wrote:
Peter Poeml wrote:
Factory actually already has 1.2.0.
Peter
You sure?
http://software.opensuse.org/search?baseproject=openSUSE%3AFactory&p=1&q=aria2
Factory search currently shows old versions, as Factory is never published. There's also a bug assigned to Adrian for this. Cheers, Michael. -- Michael Schroeder mls@suse.de SUSE LINUX Products GmbH, GF Markus Rex, HRB 16746 AG Nuernberg main(_){while(_=~getchar())putchar(~_-1/(~(_|32)/13*2-11)*13);} -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
participants (4)
-
Duncan Mac-Vicar P. -
Duncan Mac-Vicar Prett
-
Michael Schroeder -
Peter Poeml