[zypp-devel] MediaAria2c merged
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 MediaAria2c is now official part of libzypp. MediaAria2c és ara part oficial de libzypp! Author: dmacvicar Date: Tue Sep 30 00:04:58 2008 New Revision: 11212 URL: http://svn.opensuse.org/viewcvs/zypp?rev=11212&view=rev Log: - - Merge aria2c Media handler code from Google SOC 2008 (Gerard Farras) - - Only activated by making env var ZYPP_ARIA=1 - - various changes on merge: - - moved exist function to the Aria specific class - - close programs - - use arrays of commands instead of building strings - - some reformatting - - cleanup will come later TODO: Move the exceptions also in the aria class. NOTE: the default handler is still the curl one. We merge the code so people can enable it and test it. But it can't be enabled without setting the env variable. Modified: trunk/libzypp/package/libzypp.changes trunk/libzypp/zypp/CMakeLists.txt trunk/libzypp/zypp/media/MediaAccess.cc trunk/libzypp/zypp/media/MediaAccess.h trunk/libzypp/zypp/media/MediaException.cc trunk/libzypp/zypp/media/MediaException.h -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkjhUyIACgkQzR62qWZ+QtHY3gCeKGehBJ7CsU17s0xGQ/rIAn9B UkMAoJlvl0G3Meu8yGzL26pXpfyBWl0L =DUlK -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
On Tue, Sep 30, 2008 at 12:13:54 +0200, Duncan Mac-Vicar P. wrote:
MediaAria2c is now official part of libzypp.
MediaAria2c és ara part oficial de libzypp!
That's great. Thank you very much for this effort Duncan.
Author: dmacvicar Date: Tue Sep 30 00:04:58 2008 New Revision: 11212
URL: http://svn.opensuse.org/viewcvs/zypp?rev=11212&view=rev
Small sidenote, viewvc is disabled on svn.opensuse.org since a while, due to a bug, so that link isn't functional at this time. Peter -- "WARNING: This bug is visible to non-employees. Please be respectful!" SUSE LINUX Products GmbH Research & Development
Dňa Tuesday 30 September 2008 01:46:55 Peter Poeml ste napísal:
On Tue, Sep 30, 2008 at 12:13:54 +0200, Duncan Mac-Vicar P. wrote:
MediaAria2c is now official part of libzypp.
MediaAria2c és ara part oficial de libzypp!
That's great. Thank you very much for this effort Duncan.
Yes, this is really cool! Thanks a lot to all involved. Stano -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
Hi, On Tue, 30 Sep 2008, Stanislav Visnovsky wrote:
Dňa Tuesday 30 September 2008 01:46:55 Peter Poeml ste napísal:
On Tue, Sep 30, 2008 at 12:13:54 +0200, Duncan Mac-Vicar P. wrote:
MediaAria2c is now official part of libzypp.
MediaAria2c és ara part oficial de libzypp!
That's great. Thank you very much for this effort Duncan.
Yes, this is really cool! Thanks a lot to all involved.
But it would be very nice if someone cleaned up the code of MediaAria2c.cc. From a cursory read some weeks ago it is mostly a c&p of MediaCurl.cc (and in fact still uses curl for most of it's things, except of course for the crucial one of downloading files), and exchanged only a couple of functions. I'd much rather see MediaAria2c be a subclass of MediaCurl reusing much of its code. Code duplication is bad. Ciao, Michael.
Michael Matz wrote:
But it would be very nice if someone cleaned up the code of MediaAria2c.cc. From a cursory read some weeks ago it is mostly a c&p of MediaCurl.cc (and in fact still uses curl for most of it's things, except of course for the crucial one of downloading files), and exchanged only a couple of functions. I'd much rather see MediaAria2c be a subclass of MediaCurl reusing much of its code.
Yes, that is planned.
Code duplication is bad.
Does that include string join and split functions? ;-) Duncan -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
Hi, On Mon, 6 Oct 2008, Duncan Mac-Vicar Prett wrote:
Michael Matz wrote:
But it would be very nice if someone cleaned up the code of MediaAria2c.cc. From a cursory read some weeks ago it is mostly a c&p of MediaCurl.cc (and in fact still uses curl for most of it's things, except of course for the crucial one of downloading files), and exchanged only a couple of functions. I'd much rather see MediaAria2c be a subclass of MediaCurl reusing much of its code.
Yes, that is planned.
Code duplication is bad.
Does that include string join and split functions? ;-)
No, these are carefully crafted to do slightly different things everywhere, and hence can't share any code, of course :-)) Ciao, Michael. -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
On Tue, Sep 30, 2008 at 12:13:54AM +0200, Duncan Mac-Vicar P. wrote:
MediaAria2c is now official part of libzypp.
MediaAria2c és ara part oficial de libzypp!
Author: dmacvicar Date: Tue Sep 30 00:04:58 2008 New Revision: 11212
URL: http://svn.opensuse.org/viewcvs/zypp?rev=11212&view=rev Log: - - Merge aria2c Media handler code from Google SOC 2008 (Gerard Farras) - - Only activated by making env var ZYPP_ARIA=1
Empirical research has recently provided evidence that ZYPP_ARIA=1 is ineffective in activating the new handler code. ZYPP_ARIA2C=1 does it. However, it doesn't seem to work. I think there is a bug in the way that the external command is set up, and I have opened bug https://bugzilla.novell.com/show_bug.cgi?id=438971
- - various changes on merge: - - moved exist function to the Aria specific class - - close programs - - use arrays of commands instead of building strings - - some reformatting
- - cleanup will come later TODO: Move the exceptions also in the aria class.
NOTE: the default handler is still the curl one. We merge the code so people can enable it and test it. But it can't be enabled without setting the env variable.
Peter -- Contact: admin@opensuse.org (a.k.a. ftpadmin@suse.com) #opensuse-mirrors on freenode.net Info: http://en.opensuse.org/Mirror_Infrastructure SUSE LINUX Products GmbH Research & Development
Peter Poeml wrote:
However, it doesn't seem to work. I think there is a bug in the way that the external command is set up, and I have opened bug https://bugzilla.novell.com/show_bug.cgi?id=438971
Yes, when I implemented lot of options like proxy, headers and others, I screwed it up ;-) fixed. Duncan -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
On Mon, Oct 27, 2008 at 12:03:33PM +0100, Duncan Mac-Vicar Prett wrote:
Peter Poeml wrote:
However, it doesn't seem to work. I think there is a bug in the way that the external command is set up, and I have opened bug https://bugzilla.novell.com/show_bug.cgi?id=438971
Yes, when I implemented lot of options like proxy, headers and others, I screwed it up ;-) fixed.
Cool, thank you! Peter -- Contact: admin@opensuse.org (a.k.a. ftpadmin@suse.com) #opensuse-mirrors on freenode.net Info: http://en.opensuse.org/Mirror_Infrastructure SUSE LINUX Products GmbH Research & Development
participants (5)
-
Duncan Mac-Vicar P. -
Duncan Mac-Vicar Prett
-
Michael Matz -
Peter Poeml -
Stanislav Visnovsky