[zypp-devel] 7 days ago Michael Andres remove unused 'DueToObsolete' from ResStatus
7 days ago Michael Andres remove unused 'DueToObsolete' from ResStatus
make[3]: Entering directory `/tmp/rpmbuild/PackageKit-0.4.3/backends/zypp' /bin/sh ../../libtool --tag=CXX --mode=compile /opt/icecream/bin/g++ -DHAVE_CONFIG_H -I. -I../.. -I../../src -I../../lib -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -pthread -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -Wno-deprecated -DG_DISABLE_SINGLE_INCLUDES -DGTK_DISABLE_SINGLE_INCLUDES -DG_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGDK_MULTIHEAD_SAFE -DGTK_MULTIHEAD_SAFE -O2 -march=i586 -mtune=i686 -fmessage-length=0 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -MT libpk_backend_zypp_la-pk-backend-zypp.lo -MD -MP -MF .deps/libpk_backend_zypp_la-pk-backend-zypp.Tpo -c -o libpk_backend_zypp_la-pk-backend-zypp.lo `test -f 'pk-backend-zypp.cpp' || echo './'`pk-backend-zypp.cpp libtool: compile: /opt/icecream/bin/g++ -DHAVE_CONFIG_H -I. -I../.. -I../../src -I../../lib -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -pthread -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -Wno-deprecated -DG_DISABLE_SINGLE_INCLUDES -DGTK_DISABLE_SINGLE_INCLUDES -DG_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGDK_MULTIHEAD_SAFE -DGTK_MULTIHEAD_SAFE -O2 -march=i586 -mtune=i686 -fmessage-length=0 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -MT libpk_backend_zypp_la-pk-backend-zypp.lo -MD -MP -MF .deps/libpk_backend_zypp_la-pk-backend-zypp.Tpo -c pk-backend-zypp.cpp -fPIC -DPIC -o .libs/libpk_backend_zypp_la-pk-backend-zypp.o pk-backend-zypp.cpp: In function 'gboolean backend_get_requires_thread(PkBackend*)': pk-backend-zypp.cpp:221: error: 'class zypp::ResStatus' has no member named 'isToBeUninstalledDueToObsolete' ICECC[19571] 23:05:50: Compiled on 10.10.101.62 make[3]: *** [libpk_backend_zypp_la-pk-backend-zypp.lo] Error 1 make[3]: Leaving directory `/tmp/rpmbuild/PackageKit-0.4.3/backends/zypp' PackageKit breaks, what is the fix? Duncan -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
Duncan Mac-Vicar P. wrote:
7 days ago Michael Andres remove unused 'DueToObsolete' from ResStatus
make[3]: Entering directory `/tmp/rpmbuild/PackageKit-0.4.3/backends/zypp' /bin/sh ../../libtool --tag=CXX --mode=compile /opt/icecream/bin/g++ -DHAVE_CONFIG_H -I. -I../.. -I../../src -I../../lib -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -pthread -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -Wno-deprecated -DG_DISABLE_SINGLE_INCLUDES -DGTK_DISABLE_SINGLE_INCLUDES -DG_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGDK_MULTIHEAD_SAFE -DGTK_MULTIHEAD_SAFE -O2 -march=i586 -mtune=i686 -fmessage-length=0 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -MT libpk_backend_zypp_la-pk-backend-zypp.lo -MD -MP -MF .deps/libpk_backend_zypp_la-pk-backend-zypp.Tpo -c -o libpk_backend_zypp_la-pk-backend-zypp.lo `test -f 'pk-backend-zypp.cpp' || echo './'`pk-backend-zypp.cpp libtool: compile: /opt/icecream/bin/g++ -DHAVE_CONFIG_H -I. -I../.. -I../../src -I../../lib -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -pthread -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -Wno-deprecated -DG_DISABLE_SINGLE_INCLUDES -DGTK_DISABLE_SINGLE_INCLUDES -DG_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGDK_MULTIHEAD_SAFE -DGTK_MULTIHEAD_SAFE -O2 -march=i586 -mtune=i686 -fmessage-length=0 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -MT libpk_backend_zypp_la-pk-backend-zypp.lo -MD -MP -MF .deps/libpk_backend_zypp_la-pk-backend-zypp.Tpo -c pk-backend-zypp.cpp -fPIC -DPIC -o .libs/libpk_backend_zypp_la-pk-backend-zypp.o pk-backend-zypp.cpp: In function 'gboolean backend_get_requires_thread(PkBackend*)': pk-backend-zypp.cpp:221: error: 'class zypp::ResStatus' has no member named 'isToBeUninstalledDueToObsolete' ICECC[19571] 23:05:50: Compiled on 10.10.101.62 make[3]: *** [libpk_backend_zypp_la-pk-backend-zypp.lo] Error 1 make[3]: Leaving directory `/tmp/rpmbuild/PackageKit-0.4.3/backends/zypp'
PackageKit breaks, what is the fix?
Duncan
Looking at Michael's commit, would it just be ok to remove the .isToBeUninstalledDueToObsolete () case? if (it->status ().isToBeUninstalled ()) { status = PK_INFO_ENUM_REMOVING; hit = TRUE; }else if (it->status ().isToBeInstalled ()) { status = PK_INFO_ENUM_INSTALLING; hit = TRUE; }else if (it->status ().isToBeUninstalledDueToUpgrade ()) { status = PK_INFO_ENUM_UPDATING; hit = TRUE; }else if (it->status ().isToBeUninstalledDueToObsolete ()) { status = PK_INFO_ENUM_OBSOLETING; hit = TRUE; } -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
On Thursday 26 February 2009 00:21:38 Duncan Mac-Vicar P. wrote:
Duncan Mac-Vicar P. wrote:
7 days ago Michael Andres remove unused 'DueToObsolete' from ResStatus
Looking at Michael's commit, would it just be ok to remove the .isToBeUninstalledDueToObsolete () case?
if (it->status ().isToBeUninstalled ()) { status = PK_INFO_ENUM_REMOVING; hit = TRUE; }else if (it->status ().isToBeInstalled ()) { status = PK_INFO_ENUM_INSTALLING; hit = TRUE; }else if (it->status ().isToBeUninstalledDueToUpgrade ()) { status = PK_INFO_ENUM_UPDATING; hit = TRUE; }else if (it->status ().isToBeUninstalledDueToObsolete ()) { status = PK_INFO_ENUM_OBSOLETING; hit = TRUE; }
Yes, but this bit is never set. If the info is really needed we have to provide some method that computes it? In that case we should revert the change, untill we know how. (Duncan: We need to bring PkgKit to Hudson AND ALSO libzypp-testsuite! ) -- cu, Michael Andres +------------------------------------------------------------------+ Key fingerprint = 2DFA 5D73 18B1 E7EF A862 27AC 3FB8 9E3A 27C6 B0E4 +------------------------------------------------------------------+ Michael Andres YaST Development ma@novell.com SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg) Maxfeldstrasse 5, D-90409 Nuernberg, Germany, ++49 (0)911 - 740 53-0 +------------------------------------------------------------------+ -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
Michael Andres wrote:
Yes, but this bit is never set. If the info is really needed we have to provide some method that computes it? In that case we should revert the change, untill we know how.
(Duncan: We need to bring PkgKit to Hudson AND ALSO libzypp-testsuite! )
PackageKit is in hudson, but it is taken from factory sources, because the way the package is managed is tarball + patches, so the vanilla version does not build. I also modified Hudson to build now the full rpms, which avoids duplicating the build logic everywhere. It will be a little bit slower though, but you get rpms as artifacts too :-) You will see quite a lot of brakage in Hudson the following days. libzypp-testsuite, yes, you are right ;-) Duncan -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
On Thursday 26 February 2009 11:02:50 Michael Andres wrote:
On Thursday 26 February 2009 00:21:38 Duncan Mac-Vicar P. wrote:
Duncan Mac-Vicar P. wrote:
7 days ago Michael Andres remove unused 'DueToObsolete' from ResStatus
Looking at Michael's commit, would it just be ok to remove the .isToBeUninstalledDueToObsolete () case?
if (it->status ().isToBeUninstalled ()) { status = PK_INFO_ENUM_REMOVING; hit = TRUE; }else if (it->status ().isToBeInstalled ()) { status = PK_INFO_ENUM_INSTALLING; hit = TRUE; }else if (it->status ().isToBeUninstalledDueToUpgrade ()) { status = PK_INFO_ENUM_UPDATING; hit = TRUE; }else if (it->status ().isToBeUninstalledDueToObsolete ()) { status = PK_INFO_ENUM_OBSOLETING; hit = TRUE; }
Yes, but this bit is never set. If the info is really needed we have to provide some method that computes it? In that case we should revert the change, untill we know how.
I reintroduced this 'DueToObsolete' in TRUNK. And now the bit is actually set if the package is obsoleted. But the above code snippet is wrong. isToBeUninstalledDueTo* are sub cases of isToBeUninstalled. So it should look like this: if ( isToBeInstalled ) PK_INFO_ENUM_INSTALLING; else if ( isToBeUninstalled ) { if ( isToBeUninstalledDueToUpgrade ) PK_INFO_ENUM_UPDATING; else if ( isToBeUninstalledDueToObsolete ) PK_INFO_ENUM_OBSOLETING; else PK_INFO_ENUM_REMOVING; } -- cu, Michael Andres +------------------------------------------------------------------+ Key fingerprint = 2DFA 5D73 18B1 E7EF A862 27AC 3FB8 9E3A 27C6 B0E4 +------------------------------------------------------------------+ Michael Andres YaST Development ma@novell.com SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg) Maxfeldstrasse 5, D-90409 Nuernberg, Germany, ++49 (0)911 - 740 53-0 +------------------------------------------------------------------+ -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
participants (2)
-
Duncan Mac-Vicar P. -
Michael Andres