[zypp-devel] Re: [zypp-commit] r9426 - /trunk/sat-solver/tools/repo_patchxml.c
Hi Klaus, On Mon, 7 Apr 2008, kkaempf@svn.opensuse.org wrote:
Author: kkaempf Date: Mon Apr 7 16:11:23 2008 New Revision: 9426
URL: http://svn.opensuse.org/viewcvs/zypp?rev=9426&view=rev Log: parse <package-manager/> to 'update:restart' attribute
Modified: trunk/sat-solver/tools/repo_patchxml.c
@@ -81,6 +82,7 @@ { STATE_PATCH, "description", STATE_DESCRIPTION, 1 }, { STATE_PATCH, "category", STATE_CATEGORY, 1 }, { STATE_PATCH, "reboot-needed", STATE_REBOOT, 0 }, + { STATE_PATCH, "package-manager", STATE_RESTART, 0 },
You don't parse the content of this tag here (which makes sense as you mentioned "<package-manager/>", i.e. a content-less tag) ...
{ STATE_PATCH, "rpm:requires", STATE_REQUIRES, 0 }, { STATE_PATCH, "rpm:provides", STATE_PROVIDES, 0 }, { STATE_PATCH, "rpm:requires", STATE_REQUIRES, 0 }, @@ -579,6 +581,9 @@ case STATE_REBOOT: repodata_set_str(pd->data, pd->datanum, UPDATE_REBOOT, pd->content); break; + case STATE_RESTART: + repodata_set_str(pd->data, pd->datanum, UPDATE_RESTART, pd->content); + break;
... but this means that pd->content will be empty, of course. Which means it doesn't make sense to store this attribute as a string. It seems the mere existence of it has significance. If that is the case then please use repodata_set_void(). It's the same for the other attributes you recently added. Ciao, Michael. -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
* Michael Matz
... but this means that pd->content will be empty, of course. Which means it doesn't make sense to store this attribute as a string. It seems the mere existence of it has significance. If that is the case then please use repodata_set_void().
It's the same for the other attributes you recently added.
Ah, didn't know this. Thanks for pointing this out. It would be helpful to provide some documentation and example code on how to use the sat-solver attribute store. I'm still struggling with this part of sat-solver. Klaus -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
Hi, On Mon, 7 Apr 2008, Klaus Kaempf wrote:
* Michael Matz
[Apr 07. 2008 16:19]: ... but this means that pd->content will be empty, of course. Which means it doesn't make sense to store this attribute as a string. It seems the mere existence of it has significance. If that is the case then please use repodata_set_void().
It's the same for the other attributes you recently added.
Ah, didn't know this. Thanks for pointing this out.
It would be helpful to provide some documentation and example code on how to use the sat-solver attribute store.
Yeah :-| Well, okay, example code is all over the tools/ dir, but no docu :( Ciao, Michael. PS: I assume you are in the process of fixing the compilation break you caused (removal of UPDATE_xxx in favor of SOLVABLE_xxx)? Revert countdown is running :) -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
participants (2)
-
Klaus Kaempf
-
Michael Matz