mzugec@svn.opensuse.org wrote:

Author: mzugec Date: Mon Sep 22 11:21:23 2008 New Revision: 51351

URL: http://svn.opensuse.org/viewcvs/yast?rev=51351&view=rev Log: Modem: check return value of installation (bnc#387716)

Modified: trunk/network/src/modules/Modem.ycp ============================================================================== --- trunk/network/src/modules/Modem.ycp (original) +++ trunk/network/src/modules/Modem.ycp Mon Sep 22 11:21:23 2008 @@ -22,6 +22,7 @@ import "Routing"; import "Service"; import "Summary"; +import "Message"; import "SuSEFirewall4Network";

include "network/complex.ycp"; @@ -239,7 +240,8 @@

/* Setup SL modem */ if(contains(Requires, "smartlink-softmodem")) { - PackageSystem::CheckAndInstallPackages(Requires); + if(!PackageSystem::CheckAndInstallPackages(Requires)) + Popup::Error(sformat("%1 : smartlink-softmodem",Message::CannotContinueWithoutPackagesInstalled())); y2milestone("Setting up smartlink-softmodem ...");

Service::Stop("slmodemd");

Hi, How is this supposed to work? Does it really exit from the function (and modem configuration) if packages are not installed? I'd say it only reports and error and continues but maybe I'm wrong... But the error message says something different: CannotContinueWithoutPackagesInstalled, isn't it a bit confusing? Or does network check the Requires anywhere else again? Bye Lukas