Hi! For those seeing my commits on the commit list, I thought I give you a little report on what I did in your SVN: http://www.kdedevelopers.org/node/3119 What's not written in there: the way it's implemented relies on a fixed size of 1024x768 and I bet on my laptop screen to even look just as bad as on the screenshot. But that's details - and basically out of scope of ITO :) Greetings, Stephan -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org For additional commands, e-mail: yast-devel+help@opensuse.org
Stephan Kulow napsal(a):
Hi!
For those seeing my commits on the commit list, I thought I give you a little report on what I did in your SVN: http://www.kdedevelopers.org/node/3119
What's not written in there: the way it's implemented relies on a fixed size of 1024x768 and I bet on my laptop screen to even look just as bad as on the screenshot. But that's details - and basically out of scope of ITO :)
Looks great! :) Maybe it shouldn't have so much free space around (wasting space) and shouldn't rely on specific resolution but those are just a tiny details :) Well done! Lukas
Am Freitag 30 November 2007 schrieb Stephan Kulow:
Hi!
For those seeing my commits on the commit list, I thought I give you a little report on what I did in your SVN: http://www.kdedevelopers.org/node/3119
What's not written in there: the way it's implemented relies on a fixed size of 1024x768 and I bet on my laptop screen to even look just as bad as on the screenshot. But that's details - and basically out of scope of ITO :)
OK, I have it as far that I can install with a themed yast qt4 - I haven't tried the package selector lately, this is Duncan's joy :) What I wonder though: the installation creates two Wizard dialogs on top of each other - basically creating a mess with transparent windows. Why is that? One is there pretty early and the other one is created as soon as the license is displayed (testing CD with ftp instsys, so not having media check). There is a lot left for me to fix / implement, so I wonder if this is something I need to take care of too (it wouldn't be too hard, but I expect a bug somewhere else). Greetings, Stephan -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org For additional commands, e-mail: yast-devel+help@opensuse.org
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Stephan Kulow wrote:
Am Freitag 30 November 2007 schrieb Stephan Kulow: OK, I have it as far that I can install with a themed yast qt4 - I haven't tried the package selector lately, this is Duncan's joy :)
What I wonder though: the installation creates two Wizard dialogs on top of each other - basically creating a mess with transparent windows. Why is that?
One is there pretty early and the other one is created as soon as the license is displayed (testing CD with ftp instsys, so not having media check).
There is a lot left for me to fix / implement, so I wonder if this is something I need to take care of too (it wouldn't be too hard, but I expect a bug somewhere else).
Installation works this way: * Script installation.ycp creates Wizard with Steps on the left, buttons, etc * Other modules just use the created Wizard window But Licenses are special case: Because of some bugs mentioned in the code, License handler (YCP module) creates its own wizard on the top of the already created one. In my opinion, this is correct because every single module can call Wizard::OpenNextBackDialog or anything similar if needed. UI should expect such behavior. Night Lukas -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4-svn0 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iD8DBQFHXwsKVSqMdRCqTiwRAllpAJ9adYVAKP561OF/p6iZwQVusZHtxQCff4FR tYxIMoj6a1V7Dsqdr3w7NlU= =O01c -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org For additional commands, e-mail: yast-devel+help@opensuse.org
Am Dienstag 11 Dezember 2007 schrieb Lukas Ocilka:
In my opinion, this is correct because every single module can call Wizard::OpenNextBackDialog or anything similar if needed. UI should expect such behavior.
Sure, but you can't expect it to look nice and integrated if wizards opens wizards and this is what's happening: it flickers like mad because the full screen is updated. The UI layer may be a toolkit, but that doesn't mean it can do magic. So I read the bug report, but I don't see why a new wizard has to be opened on top of the other wizard. BTW: from what I can see in the widget stack is that the two wizards are kept open, is _that_ a bug in the wizard module or the productlicense module? Greetings, Stephan -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org For additional commands, e-mail: yast-devel+help@opensuse.org
Stephan Kulow wrote:
Am Dienstag 11 Dezember 2007 schrieb Lukas Ocilka:
In my opinion, this is correct because every single module can call Wizard::OpenNextBackDialog or anything similar if needed. UI should expect such behavior.
Sure, but you can't expect it to look nice and integrated if wizards opens wizards and this is what's happening: it flickers like mad because the full screen is updated.
The UI layer may be a toolkit, but that doesn't mean it can do magic. So I read the bug report, but I don't see why a new wizard has to be opened on top of the other wizard.
BTW: from what I can see in the widget stack is that the two wizards are kept open, is _that_ a bug in the wizard module or the productlicense module?
It actually might be a bug in UI but I would have to see that, of course. Anyway, two wizards kept open are probably a bug. The ProductLicense case is this: * Open a Wizard (Installation) * Select some Online Repositories to be used * Wizard content is replaced with a Progress -> Adding repository A -> Adding repository B ... * When a Repository A, B, ... has a license, it needs to be somehow displayed and accepted. But we can't break the current progress dialog and then return back after the license gets accepted. That's why a new Wizard window gets opened, license displayed and the Wizard is closed then (to continue with the progress). OK, it needn't be a Wizard::OpenBackNextStepsDialog but a normal UI::OpenDialog. Of course, it needs to be closed (and it always is - in openSUSE 10.3). BTW: Opening a Wizard on top of another one is a pretty common behavior, for instance when one YaST module calls another (Repositories call Community Repositories, Users might call Kerberos or another auth-method module, Timezone can call NTP Configuration, ...). Opening a new wizard is always safe because if your module is the one that is called, it opens a windows and then closes it. Your module doesn't need to take care what was in the Wizard dialog before and what remains there if your module finishes. Bye Lukas
participants (2)
-
Lukas Ocilka -
Stephan Kulow