[yast-devel] Re: [yast-commit] r64721 - in /trunk/wagon: package/yast2-wagon.changes src/clients/welcome_in_wagon.ycp
On Po 4. Júl 2011 13:38:34 lslezak@svn2.opensuse.org wrote:
Author: lslezak Date: Mon Jul 4 13:38:33 2011 New Revision: 64721
URL: http://svn.opensuse.org/viewcvs/yast?rev=64721&view=rev Log: wagon - if the system is managed by SUSE Manager display a message and exit (fate#311994)
What about creating a library out of this functionality? Stano
Modified: trunk/wagon/package/yast2-wagon.changes trunk/wagon/src/clients/welcome_in_wagon.ycp
Modified: trunk/wagon/package/yast2-wagon.changes URL: http://svn.opensuse.org/viewcvs/yast/trunk/wagon/package/yast2-wagon.chang es?rev=64721&r1=64720&r2=64721&view=diff ========================================================================== ==== --- trunk/wagon/package/yast2-wagon.changes (original) +++ trunk/wagon/package/yast2-wagon.changes Mon Jul 4 13:38:33 2011 @@ -1,4 +1,10 @@ ------------------------------------------------------------------- +Mon Jul 4 11:28:46 UTC 2011 - lslezak@suse.cz + +- if the system is managed by SUSE Manager display a message + and exit (fate#311994) + +------------------------------------------------------------------- Fri Jul 1 08:52:27 UTC 2011 - lslezak@suse.cz
- .spec file - fixed file list
Modified: trunk/wagon/src/clients/welcome_in_wagon.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/wagon/src/clients/welcome_in_wa gon.ycp?rev=64721&r1=64720&r2=64721&view=diff ========================================================================== ==== --- trunk/wagon/src/clients/welcome_in_wagon.ycp (original) +++ trunk/wagon/src/clients/welcome_in_wagon.ycp Mon Jul 4 13:38:33 2011 @@ -21,6 +21,7 @@ import "Popup"; import "Wagon"; import "Report"; + import "FileUtils";
textdomain "wagon";
@@ -41,6 +42,18 @@ GetInstArgs::enable_back(), GetInstArgs::enable_next()); Wizard::EnableAbortButton ();
+ // file /etc/sysconfig/rhn/systemid means the system is managed by SUSE Manager + if (FileUtils::Exists("/etc/sysconfig/rhn/systemid")) + { + y2milestone("File /etc/sysconfig/rhn/systemid found, aborting wagon"); + + // warning message, system managed by SUSE Manager cannot be migrated by wagon + // display this message and exit + Popup::Message(_("This system is managed by SUSE Manager,\nYaST wagon module cannot migrate systems managed by SUSE Manager.\n\nPress OK to exit.")); + + return (any)`back; + } + any ret = nil;
while (true) {
-- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org For additional commands, e-mail: yast-devel+help@opensuse.org
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Dne 4.7.2011 14:41, Stanislav Visnovsky napsal(a):
On Po 4. Júl 2011 13:38:34 lslezak@svn2.opensuse.org wrote:
Author: lslezak Date: Mon Jul 4 13:38:33 2011 New Revision: 64721
URL: http://svn.opensuse.org/viewcvs/yast?rev=64721&view=rev Log: wagon - if the system is managed by SUSE Manager display a message and exit (fate#311994)
What about creating a library out of this functionality?
Sounds like a very good idea! Such functionality (in general) - if it's reusable - should always be part of some library. Lukas - -- Lukas Ocilka, Appliances Department, SUSE LINUX s.r.o. MD: Jeff Hawn, Jennifer Guild, Alena Hendrichova -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iD8DBQFOEb9zVSqMdRCqTiwRAoMkAJ0essSOXOGWxnE/dVaAc7+s0Nu43ACfR18L NtKRRIH1hZ8I+lM06LIYfGM= =SC8H -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org For additional commands, e-mail: yast-devel+help@opensuse.org
Dne 4.7.2011 15:26, Lukas Ocilka napsal(a):
Dne 4.7.2011 14:41, Stanislav Visnovsky napsal(a):
On Po 4. Júl 2011 13:38:34 lslezak@svn2.opensuse.org wrote:
Author: lslezak Date: Mon Jul 4 13:38:33 2011 New Revision: 64721
URL: http://svn.opensuse.org/viewcvs/yast?rev=64721&view=rev Log: wagon - if the system is managed by SUSE Manager display a message and exit (fate#311994)
What about creating a library out of this functionality?
Sounds like a very good idea!
Such functionality (in general) - if it's reusable - should always be part of some library.
Um, I have checked yast2.rpm and I didn't find any suitable existing library (YCP module). Do we want to have SuseManager.ycp or some generic SystemProperties.ycp (or something like that)? Is there any other SUSE Manager related functionality we want to share? If yes SuseManager.ycp would be the right place, if not I think it would be better to put it into a generic module which can be enhanced with similar functionality but not related to SUSE Manager. Any comments? -- Best Regards Ladislav Slezák Yast Developer ------------------------------------------------------------------------ SUSE LINUX, s.r.o. e-mail: lslezak@suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz/ -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org For additional commands, e-mail: yast-devel+help@opensuse.org
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Dne 4.7.2011 15:54, Ladislav Slezak napsal(a):
Um, I have checked yast2.rpm and I didn't find any suitable existing library (YCP module).
Do we want to have SuseManager.ycp or some generic SystemProperties.ycp (or something like that)?
Is there any other SUSE Manager related functionality we want to share? If yes SuseManager.ycp would be the right place, if not I think it would be better to put it into a generic module which can be enhanced with similar functionality but not related to SUSE Manager.
Any comments?
IMO belongs to Register.ycp but that would probably bring a new dependency. In that case SuseManager.ycp in yast2.rpm sounds appropriate. Lukas - -- Lukas Ocilka, Appliances Department, SUSE LINUX s.r.o. MD: Jeff Hawn, Jennifer Guild, Alena Hendrichova -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iD8DBQFOEcutVSqMdRCqTiwRAiCPAJ9klKTF5K65NTqF81dwFbl6Rh45hACfa1B/ 2rsqT3EsSbURw12HxNFEVZs= =6f5v -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org For additional commands, e-mail: yast-devel+help@opensuse.org
On Po 4. Júl 2011 16:18:21 Lukas Ocilka wrote:
Dne 4.7.2011 15:54, Ladislav Slezak napsal(a):
Um, I have checked yast2.rpm and I didn't find any suitable existing library (YCP module).
Do we want to have SuseManager.ycp or some generic SystemProperties.ycp (or something like that)?
Is there any other SUSE Manager related functionality we want to share? If yes SuseManager.ycp would be the right place, if not I think it would be better to put it into a generic module which can be enhanced with similar functionality but not related to SUSE Manager.
Any comments?
IMO belongs to Register.ycp but that would probably bring a new dependency. In that case SuseManager.ycp in yast2.rpm sounds appropriate.
I think a similar library should be to figure out if the system is managed by puppet, so I rather see a generic library for reporting if a system is managed by mass-management solution. Stano -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org For additional commands, e-mail: yast-devel+help@opensuse.org
participants (3)
-
Ladislav Slezak -
Lukas Ocilka -
Stanislav Visnovsky