V Fri, 14 Jul 2017 16:00:06 -0500 Goldwyn Rodrigues napsáno:

Hi,

I removed a lot of files from yast-apparmor and when I comitted it, travis complained [1] of build errors. I have removed a lot of non-yast server_y2 script files and added src/lib directory for most of the processing.

However, when I put in a pull request, the build fails. To look for examples, I checked how other yast projects are doing this, I found that most of the yast projects are either using Makefiles or using the lib directory, but not both. Is it specific to yast projects which use server_non_y2? Is it safe to remove the Makefiles too? If yes, what changes do I have to make to the spec file? Just adding %{yast_libdir}/apparmor enough? Where can I read more about these macros?

[1] https://travis-ci.org/yast/yast-apparmor/builds/253684620?utm_source=github_status&utm_medium=notification

Hi, it is possible to have both. For example see https://github.com/yast/yast-yast2/tree/master/library/general/src where makefile looks like https://github.com/yast/yast-yast2/blob/master/library/general/src/Makefile.... from your branch libdir is missing at https://github.com/yast/yast-apparmor/pull/14/files#diff-480477e89f9b6ddafb3... also its dir is not specified at https://github.com/yast/yast-apparmor/pull/14/files#diff-480477e89f9b6ddafb3... Josef -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org