Dne 30.6.2011 13:27, gs@svn2.opensuse.org napsal(a): [...]

+ fcoe_config = FcoeClient::GetFcoeConfig(); + summary = Summary::AddLine( summary, sformat( "DEBUG: %1", fcoe_config["DEBUG"]:"" ) ); + summary = Summary::AddLine( summary, sformat( "USE SYSLOG: %1", fcoe_config["USE_SYSLOG"]:"" ) );

Just some notes: The translation marks are missing. I guess these values mean the direct config options, I think there should be rather some human readable texts instead.

+ summary = Summary::AddLine( summary, _("<b>Starting of services</b>") ); + summary = Summary::AddLine( summary, sformat( "fcoe: %1", (service_start["fcoe"]:false)?"true":"false" ) ); + summary = Summary::AddLine( summary, sformat( "lldpad: %1", (service_start["lldpad"]:false)?"true":"false" ) );

The same here: no translation. Although "fcoe" might seem to be untranslatable translation allows to change the order which is essential in RTL (right-to-left) languages (like arabic). But again, here I'd rather see a service description text instead of the abbreviations (lldpad? WTF? Do I need it?). Do not use "true" "false" but rather _("Enabled") _("Disabled") to be consistent with other proposals. And the summary is printed in proportion font (in GUI) so the spaces do not guarantee any alignment in the output, just one space is enough IMO. -- Best Regards Ladislav Slezák Yast Developer ------------------------------------------------------------------------ SUSE LINUX, s.r.o. e-mail: lslezak@suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz/ -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org For additional commands, e-mail: yast-devel+help@opensuse.org