On Thu, 12 Jan 2012 10:33:58 -0000 fehr@svn2.opensuse.org wrote:

Author: fehr Date: Thu Jan 12 11:33:58 2012 New Revision: 67153

URL: http://svn.opensuse.org/viewcvs/yast?rev=67153&view=rev Log: remove portal group from target portal (bnc#738037)

Modified: trunk/iscsi-client/package/yast2-iscsi-client.changes trunk/iscsi-client/src/IscsiClientLib.ycp

Modified: trunk/iscsi-client/package/yast2-iscsi-client.changes URL: http://svn.opensuse.org/viewcvs/yast/trunk/iscsi-client/package/yast2-iscsi-client.changes?rev=67153&r1=67152&r2=67153&view=diff ============================================================================== --- trunk/iscsi-client/package/yast2-iscsi-client.changes (original) +++ trunk/iscsi-client/package/yast2-iscsi-client.changes Thu Jan 12 11:33:58 2012 @@ -1,5 +1,10 @@ ------------------------------------------------------------------- -Tue Dec 6 18:22:15 UTC 2011 - per@opensuse.org +Thu Jan 12 11:28:17 CET 2012 - fehr@suse.de + +- remove portal group from target portal (bnc#738037) + +------------------------------------------------------------------- +Tue Dec 6 18:22:15 UTC 2011 - per@opensuse.org

- fix parsing of iscsiadm output in IscsiClientLib.ycp (bnc#725182)

Modified: trunk/iscsi-client/src/IscsiClientLib.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/iscsi-client/src/IscsiClientLib.ycp?rev=67153&r1=67152&r2=67153&view=diff ============================================================================== --- trunk/iscsi-client/src/IscsiClientLib.ycp (original) +++ trunk/iscsi-client/src/IscsiClientLib.ycp Thu Jan 12 11:33:58 2012 @@ -264,6 +264,9 @@ portal = splitstring(row, " ")[2]:""; else if( search(row,"Persistent Portal:")==nil ) portal = splitstring(row, " ")[1]:""; + integer pos = search(portal,","); + if( pos != nil ) + portal = substring( portal, 0, pos );

Hi, I know that you could abstract information from version system, but it quite helps if you add comment with bug number to every non-obvious code, so then we can easily clean code ( we just open bugzilla and check if reason is still valid ). Thanks Josef

} else if( search(row,"Iface Name:")!=nil ) {

-- Josef Reidinger Software Engineer Appliance Department SUSE LINUX, s. r. o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic jreidinger@suse.com SUSE -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org