[yast-devel] Re: [yast-commit] r66414 - in /branches/SuSE-Code-11-SP2-Branch/snapper: VERSION package/yast2-snapper.changes src/dialogs.ycp
Dne 13.10.2011 10:41, jsuchome@svn2.opensuse.org napsal(a):
+ if (!textmode) + { + // show fixed font in diff + diff = "<tt>" + diff + "</tt>"; + }
Is the condition necessary? I'd expect that ncurses would do nothing if <tt> is found and simply ignore it as they cannot change terminal font. The same with <font>. Or does it cause some side effects in ncurses UI? -- Ladislav Slezák Appliance department / YaST Developer Lihovarská 1060/12 190 00 Prague 9 / Czech Republic tel: +420 284 028 960 lslezak@suse.com SUSE -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
Dne Čt 13. října 2011 13:34:27 Ladislav Slezak napsal(a):
Dne 13.10.2011 10:41, jsuchome@svn2.opensuse.org napsal(a):
+ if (!textmode) + { + // show fixed font in diff + diff = "<tt>" + diff + "</tt>"; + }
Is the condition necessary? I'd expect that ncurses would do nothing if <tt> is found and simply ignore it as they cannot change terminal font. The same with <font>. Or does it cause some side effects in ncurses UI?
Yes, it somehow highlights the text in the richtext, which looks bad (see attached example). It might be bug in ncurses UI, but now I needed quick solution for yast2-snapper. Gabi? Jiri -- Jiri Suchomel SUSE LINUX, s.r.o. e-mail: jsuchome@suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Praha 9, Czech Republic http://www.suse.cz
Dne Čt 13. října 2011 15:39:23 Jiri Suchomel napsal(a):
Dne Čt 13. října 2011 13:34:27 Ladislav Slezak napsal(a):
Is the condition necessary? I'd expect that ncurses would do nothing if <tt> is found and simply ignore it as they cannot change terminal font. The same with <font>. Or does it cause some side effects in ncurses UI?
Yes, it somehow highlights the text in the richtext, which looks bad (see attached example). It might be bug in ncurses UI, but now I needed quick solution for yast2-snapper.
I forgot to say that I meant <tt> tag here. As for the <font> tag, it does not have any effect in ncurses (correctly, although it would be nice if it'd work), I'm skipping it in code just to make things faster (at least for text mode). j -- Jiri Suchomel SUSE LINUX, s.r.o. e-mail: jsuchome@suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Praha 9, Czech Republic http://www.suse.cz -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Dne 13.10.2011 16:04, Jiri Suchomel napsal(a):
Dne Čt 13. října 2011 15:39:23 Jiri Suchomel napsal(a):
Dne Čt 13. října 2011 13:34:27 Ladislav Slezak napsal(a):
Is the condition necessary? I'd expect that ncurses would do nothing if <tt> is found and simply ignore it as they cannot change terminal font. The same with <font>. Or does it cause some side effects in ncurses UI?
Yes, it somehow highlights the text in the richtext, which looks bad (see attached example). It might be bug in ncurses UI, but now I needed quick solution for yast2-snapper.
So it's IMO worth a bugreport, isn't it? Bye Lukas - -- Lukas Ocilka, Appliances Department, SUSE LINUX s.r.o. MD: Jeff Hawn, Jennifer Guild, Alena Hendrichova -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk6W/v8ACgkQVSqMdRCqTizHGACcDHZlmgikbiv6dnaYiFQNfB5v m7sAn2WOFFtovFyPlhcXBM+0GKtCfBUq =1zaJ -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
Dne 13.10.2011 15:39, Jiri Suchomel napsal(a): [...]
Is the condition necessary? I'd expect that ncurses would do nothing if <tt> is found and simply ignore it as they cannot change terminal font. The same with <font>. Or does it cause some side effects in ncurses UI?
Yes, it somehow highlights the text in the richtext, which looks bad (see attached example). It might be bug in ncurses UI, but now I needed quick solution for yast2-snapper.
Ah, I see, thanks for the info. -- Ladislav Slezák Appliance department / YaST Developer Lihovarská 1060/12 190 00 Prague 9 / Czech Republic tel: +420 284 028 960 lslezak@suse.com SUSE -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
participants (3)
-
Jiri Suchomel -
Ladislav Slezak -
Lukas Ocilka