YaST Development

Download

yast-devel@lists.opensuse.org

July 2011

18 participants
22 discussions

[yast-devel] Re: [yast-commit] r64609 - in /trunk/add-on: VERSION package/yast2-add-on.changes src/add-on-workflow.ycp
by Martin Vidner 01 Jul '11

01 Jul '11

On Tue, Jun 28, 2011 at 09:35:08AM -0000, lslezak(a)svn2.opensuse.org wrote: > URL: http://svn.opensuse.org/viewcvs/yast?rev=64609&view=rev > > Modified: trunk/add-on/src/add-on-workflow.ycp > URL: http://svn.opensuse.org/viewcvs/yast/trunk/add-on/src/add-on-workflow.ycp?r… > ============================================================================== > --- trunk/add-on/src/add-on-workflow.ycp (original) > +++ trunk/add-on/src/add-on-workflow.ycp Tue Jun 28 11:35:07 2011 > @@ -180,6 +180,8 @@ > y2milestone ("Starting repository sequence"); > symbol ret = Sequencer::Run (aliases, sequence); > > + if (ret != `abort) > + { > list <integer> sources_after = Pkg::SourceGetCurrent (false); > y2milestone ("Sources with new one added: %1", sources_after); > > @@ -219,6 +221,7 @@ > y2milestone ("Saving all sources"); > Pkg::SourceSaveAll(); > } > + } Ha! Bad indentation! Please indent the code that is being put in a condition. If you think that would be too much indentation, maybe it's a good opportunity to factor it out. > > AddOnProduct::last_ret = ret; > y2milestone ("MediaSelect Dialog ret: %1", ret); -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu

1 1

[yast-devel] Re: [yast-commit] r64694 - in /branches/SuSE-Code-11-SP2-Branch/add-on: package/yast2-add-on.changes src/add-on_auto.ycp
by Ladislav Slezak 01 Jul '11

01 Jul '11

Dne 1.7.2011 11:06, ug(a)svn2.opensuse.org napsal(a): > Modified: branches/SuSE-Code-11-SP2-Branch/add-on/src/add-on_auto.ycp > URL: http://svn.opensuse.org/viewcvs/yast/branches/SuSE-Code-11-SP2-Branch/add-o… > ============================================================================== > --- branches/SuSE-Code-11-SP2-Branch/add-on/src/add-on_auto.ycp (original) > +++ branches/SuSE-Code-11-SP2-Branch/add-on/src/add-on_auto.ycp Fri Jul 1 11:06:03 2011 > @@ -161,6 +161,13 @@ > AddOnProduct::add_on_products = maplist (map <string, any> prod, AddOnProduct::add_on_products, { > string media = prod["media_url"]:""; > string pth = prod["product_dir"]:"/"; > + > + if( issubstring( media, "relurl://" ) ) { Here I'd rather use String::StartsWith(media, "relurl://") although it is very unlikely that "relurl://" would be in the middle of the URL... -- Best Regards Ladislav Slezák Yast Developer ------------------------------------------------------------------------ SUSE LINUX, s.r.o. e-mail: lslezak(a)suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz/ -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0