June 2011 - YaST Development - openSUSE Mailing Lists

[yast-devel] Re: [yast-commit] r64385 - /trunk/ncurses/src/NCstyle.mono.h
by Martin Vidner 15 Jun '11

15 Jun '11

> URL: http://svn.opensuse.org/viewcvs/yast?rev=64385&view=rev > Log: > adjust value for progress bar background The commit message merely states WHAT is being changed, which is already apparent from the code itself. Please remember to say WHY a change is being made. > > Modified: > trunk/ncurses/src/NCstyle.mono.h > > Modified: trunk/ncurses/src/NCstyle.mono.h > URL: http://svn.opensuse.org/viewcvs/yast/trunk/ncurses/src/NCstyle.mono.h?rev=6… > ============================================================================== > --- trunk/ncurses/src/NCstyle.mono.h (original) > +++ trunk/ncurses/src/NCstyle.mono.h Wed Jun 15 11:47:03 2011 > @@ -93,7 +93,7 @@ > attrset->setAttr( NCstyle::RichTextIT, 0 | A_REVERSE ); > attrset->setAttr( NCstyle::RichTextBIT, 0 | A_REVERSE ); > attrset->setAttr( NCstyle::ProgbarCh, 0 | A_BOLD ); > - attrset->setAttr( NCstyle::ProgbarBgch, 4194481 ); > + attrset->setAttr( NCstyle::ProgbarBgch, 16160 ); > attrset->setAttr( NCstyle::TextCursor, 0 | A_REVERSE | A_BOLD ); > // InfoStyle > attrset = &styleSet[NCstyle::InfoStyle].getAttrLocal(); > @@ -156,7 +156,7 @@ > attrset->setAttr( NCstyle::RichTextIT, 0 | A_REVERSE ); > attrset->setAttr( NCstyle::RichTextBIT, 0 | A_REVERSE ); > attrset->setAttr( NCstyle::ProgbarCh, 0 | A_BOLD ); > - attrset->setAttr( NCstyle::ProgbarBgch, 4194481 ); > + attrset->setAttr( NCstyle::ProgbarBgch, 16160 ); > attrset->setAttr( NCstyle::TextCursor, 0 | A_REVERSE | A_BOLD ); > // WarnStyle > attrset = &styleSet[NCstyle::WarnStyle].getAttrLocal(); > @@ -219,7 +219,7 @@ > attrset->setAttr( NCstyle::RichTextIT, 0 | A_REVERSE ); > attrset->setAttr( NCstyle::RichTextBIT, 0 | A_REVERSE ); > attrset->setAttr( NCstyle::ProgbarCh, 0 | A_BOLD ); > - attrset->setAttr( NCstyle::ProgbarBgch, 4194481 ); > + attrset->setAttr( NCstyle::ProgbarBgch, 16160 ); > attrset->setAttr( NCstyle::TextCursor, 0 | A_REVERSE | A_BOLD ); > // PopupStyle > attrset = &styleSet[NCstyle::PopupStyle].getAttrLocal(); > @@ -282,7 +282,7 @@ > attrset->setAttr( NCstyle::RichTextIT, 0 | A_REVERSE ); > attrset->setAttr( NCstyle::RichTextBIT, 0 | A_REVERSE ); > attrset->setAttr( NCstyle::ProgbarCh, 0 | A_BOLD ); > - attrset->setAttr( NCstyle::ProgbarBgch, 4194481 ); > + attrset->setAttr( NCstyle::ProgbarBgch, 16160 ); > attrset->setAttr( NCstyle::TextCursor, 0 | A_REVERSE | A_BOLD ); > } > > > -- > To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org > For additional commands, e-mail: yast-commit+help(a)opensuse.org > -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu

1 0

[yast-devel] Re: [yast-commit] r64329 - /trunk/yast2/library/control/src/ProductProfile.ycp
by Martin Vidner 15 Jun '11

15 Jun '11

On Tue, Jun 14, 2011 at 06:43:07AM -0000, jsuchome(a)svn2.opensuse.org wrote: > Author: jsuchome > Date: Tue Jun 14 08:43:07 2011 > New Revision: 64329 > > URL: http://svn.opensuse.org/viewcvs/yast?rev=64329&view=rev > Log: > module for handling product profiles (fate#310730) > > Added: > trunk/yast2/library/control/src/ProductProfile.ycp (with props) > > Added: trunk/yast2/library/control/src/ProductProfile.ycp > URL: http://svn.opensuse.org/viewcvs/yast/trunk/yast2/library/control/src/Produc… > ============================================================================== > --- trunk/yast2/library/control/src/ProductProfile.ycp (added) > +++ trunk/yast2/library/control/src/ProductProfile.ycp Tue Jun 14 08:43:07 2011 > @@ -0,0 +1,153 @@ > +/** > + * File: modules/ProductProfile.ycp > + * Package: yast2 > + * Summary: Functions for handling Product Profiles > + * Authors: Jiri Suchomel <jsuchome(a)suse.cz> > + * > + * $Id$ > + */ > +{ > + textdomain "base"; > + module "ProductProfile"; > + > + import "Mode"; > + import "Report"; > + import "YaPI::SubscriptionTools"; Where is this module? I guess yast2.rpm should have a dependency on it. > + > + // path to the profile file on the media > + string profile_path = "/profile.prod"; //FIXME the name > + > + // Result map of isCompliance call. > + // If map is not empty, contains reasons why system is not compliant. > + map<string,any> compliance = $[]; > + > + // profiles for all installed products From an earlier commit, it is apparent that the strings are filenames (as opposed to contents of the files). Please mention that in the comment. How is the variable initialized? Wouldn't it be better to use a function, like GetComplianceMap does with compliance? > + global list<string> all_profiles = []; > + > + // return the result of last compliance test > + global map<string,any> GetComplianceMap () { > + return compliance; > + } > + > + /** > + * Checks the profile compliance with the system. > + * @param if productId is not nil, check only compliance with given product > + * (once new product is added, function should be called to with new product ID) > + * @ret true if the system is compliant > + */ > + global boolean IsCompliant (integer productId) { > + > + list<string> profiles = []; > + list<map> products = []; > + list<string> sigkeys = []; > + > + // iterate all (or given) products and get the info about them > + foreach (map product, Pkg::ResolvableProperties ("", `product, ""), { > + > + integer src_id = product["source"]:-1; > + > + if (product["status"]:`none != `selected) > + return; > + > + if (productId != nil && src_id != productId) > + return; > + > + // generate product map: > + list<string> version_release = splitstring (product["version"]:"", "-"); > + products = add (products, $[ > + "arch" : product["arch"]:"", > + "name" : product["name"]:"", > + "version" : version_release[0]:"", > + "release" : version_release[1]:"", > + "vendor" : product["vendor"]:"" > + ]); > + > + // FIXME it might be needed to check to directory.yast as well for *.profile > + string profile = Pkg::SourceProvideOptionalFile (src_id, 1, profile_path); > + if (profile != nil) > + { > + profiles = add (profiles, profile); > + } > + > + // find the list of sigkeys Comments like these are asking for a function: list<string> SourceSigkeys (integer src_id) { ... } > + string dir_file = Pkg::SourceProvideOptionalFile (src_id, 1, "/directory.yast"); > + map out = (map) SCR::Execute (.target.bash_output, sformat ( > + "grep 'gpg-pubkey' %1 2>/dev/null", dir_file)); > + list<string> keys = filter (string k, splitstring (out["stdout"]:"", "\n"), ``(k != "")); > + > + y2internal ("keys for %1: %2", src_id, keys); > + > + sigkeys = (list<string>) union (sigkeys, keys); > + }); > + > + // remember profiles so they can be copied them to the installed system > + all_profiles = union (all_profiles, profiles); > + > + y2internal ("products: %1", products); > + > + if (profiles == []) > + { > + y2milestone ("no product profile present"); > + compliance = $[]; > + return true; > + } > + > + compliance = YaPI::SubscriptionTools::isCompliant (profiles, products, sigkeys); > + return (compliance == nil); > + } > + > + > + /** > + * Checks the profile compliance with the system. > + * If system is not complient, shows a popup with reasons and asks > + * to continue with the installation. > + * @ret Returns true if system is complient or user agrees to continue > + * although the complience test failed. > + * @param if productId is not nil, check only compliance with given product > + * (once new product is added, function should be called to with new product ID) > + */ > + global boolean CheckCompliance (integer productId) { > + > + // behavior for non-installation not defined yet > + if (!Mode::installation ()) > + { > + return true; > + } > + > + if (IsCompliant (productId)) > + { > + return true; > + } > + > + list<string> reasons = []; > + foreach (string key, any val, compliant, { > + y2internal ("key %1, val %2", key, val); > + if (is (val, map) && haskey ((map)val, "message")) > + { > + reasons = add (reasons, ((map)val)["message"]:""); > + } > + }); > + list<string> reasons = [ > + "Architecture(x86_64) is not one of: s390x, i586", > + "Number of CPU cores(2) exceeds 1" > + ]; Are you sure to redeclare reasons? Is this a forgotten example list? > + > + return Report::AnyQuestion ( > + // popup dialog caption > + _("Warning"), > + // popup message, %1 is list of problems > + sformat (_("The system is not compliant with provided profile: > + > +%1 > + > +Do you want to continue or abort the installation?"), > + mergestring (reasons, "\n") > + ), > + // button label > + _("&Continue Installation"), > + // button label > + _("&Abort Installation"), > + `no_button > + ); > + } > +} > > -- > To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org > For additional commands, e-mail: yast-commit+help(a)opensuse.org > -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu

3 4

[yast-devel] Re: [yast-commit] r64357 - in /branches/SuSE-Code-11-SP2-Branch/apparmor: VERSION package/yast2-apparmor.changes
by Martin Vidner 14 Jun '11

14 Jun '11

On Tue, Jun 14, 2011 at 01:54:40PM -0000, jreidinger(a)svn2.opensuse.org wrote: > Author: jreidinger > Date: Tue Jun 14 15:54:40 2011 > New Revision: 64357 > > URL: http://svn.opensuse.org/viewcvs/yast?rev=64357&view=rev > Log: > changes > > Modified: > branches/SuSE-Code-11-SP2-Branch/apparmor/VERSION > branches/SuSE-Code-11-SP2-Branch/apparmor/package/yast2-apparmor.changes > > Modified: branches/SuSE-Code-11-SP2-Branch/apparmor/VERSION > URL: http://svn.opensuse.org/viewcvs/yast/branches/SuSE-Code-11-SP2-Branch/appar… > ============================================================================== > --- branches/SuSE-Code-11-SP2-Branch/apparmor/VERSION (original) > +++ branches/SuSE-Code-11-SP2-Branch/apparmor/VERSION Tue Jun 14 15:54:40 2011 > @@ -1 +1 @@ > -2.17.8 > +2.17.9 > > Modified: branches/SuSE-Code-11-SP2-Branch/apparmor/package/yast2-apparmor.changes > URL: http://svn.opensuse.org/viewcvs/yast/branches/SuSE-Code-11-SP2-Branch/appar… > ============================================================================== > --- branches/SuSE-Code-11-SP2-Branch/apparmor/package/yast2-apparmor.changes (original) > +++ branches/SuSE-Code-11-SP2-Branch/apparmor/package/yast2-apparmor.changes Tue Jun 14 15:54:40 2011 > @@ -1,6 +1,13 @@ > ------------------------------------------------------------------- > Thu Mar 11 15:47:28 CET 2010 - kmachalkova(a)suse.cz not really > +- Merge apparmor module into one desktop entry (FATE#305278) > +- fix typos in translatable strings (BNC#693326 ) 859! > +- 2.17.9 > + > +------------------------------------------------------------------- > +Thu Mar 11 15:47:28 CET 2010 - kmachalkova(a)suse.cz > + > - Backport of bnc#538245 bugfix. This solves untranslated tooltips > of AA modules (now bnc#583643) > - 2.17.8 > > -- > To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org > For additional commands, e-mail: yast-commit+help(a)opensuse.org > -- Martin Vidner, YaST developer ( http://xkcd.com/859/ Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu

1 0

[yast-devel] Re: [yast-commit] r64343 - in /trunk/wagon: ./ VERSION package/yast2-wagon.changes src/clients/wagon_update_proposal.ycp src/config/cd_update.desktop src/modules/Wagon.ycp yast2-wagon.spec.in
by Martin Vidner 14 Jun '11

14 Jun '11

On Tue, Jun 14, 2011 at 12:00:23PM -0000, lslezak(a)svn2.opensuse.org wrote: > Author: lslezak > Date: Tue Jun 14 14:00:22 2011 > New Revision: 64343 > > URL: http://svn.opensuse.org/viewcvs/yast?rev=64343&view=rev > Log: > - implemented download in advance mode support (fate#308951) > - 2.21.0 > > Modified: > trunk/wagon/ (props changed) > trunk/wagon/VERSION > trunk/wagon/package/yast2-wagon.changes > trunk/wagon/src/clients/wagon_update_proposal.ycp > trunk/wagon/src/config/cd_update.desktop (props changed) > trunk/wagon/src/modules/Wagon.ycp (contents, props changed) > trunk/wagon/yast2-wagon.spec.in > > Modified: trunk/wagon/VERSION > URL: http://svn.opensuse.org/viewcvs/yast/trunk/wagon/VERSION?rev=64343&r1=64342… > ============================================================================== > --- trunk/wagon/VERSION (original) > +++ trunk/wagon/VERSION Tue Jun 14 14:00:22 2011 > @@ -1 +1 @@ > -2.20.3 > +2.21.0 > > Modified: trunk/wagon/package/yast2-wagon.changes > URL: http://svn.opensuse.org/viewcvs/yast/trunk/wagon/package/yast2-wagon.change… > ============================================================================== > --- trunk/wagon/package/yast2-wagon.changes (original) > +++ trunk/wagon/package/yast2-wagon.changes Tue Jun 14 14:00:22 2011 > @@ -1,4 +1,10 @@ > ------------------------------------------------------------------- > +Tue Jun 14 08:42:02 UTC 2011 - lslezak(a)suse.cz > + > +- implemented download in advance mode support (fate#308951) > +- 2.21.0 > + > +------------------------------------------------------------------- > Fri Feb 18 14:22:27 CET 2011 - locilka(a)suse.cz > > - yast2-wagon control files have been moved to separate packages > > Modified: trunk/wagon/src/clients/wagon_update_proposal.ycp > URL: http://svn.opensuse.org/viewcvs/yast/trunk/wagon/src/clients/wagon_update_p… > ============================================================================== > --- trunk/wagon/src/clients/wagon_update_proposal.ycp (original) > +++ trunk/wagon/src/clients/wagon_update_proposal.ycp Tue Jun 14 14:00:22 2011 > @@ -20,6 +20,7 @@ > > import "Wagon"; > import "Report"; > + import "PackageInstallation"; > > string func = (string) WFM::Args(0); > map param = (map) WFM::Args(1); > @@ -40,11 +41,23 @@ > } > > Wagon::ProposeDUP(); > + Wagon::ProposeDownloadMode(); > > ret = Wagon::ProposalSummary(); > > } else if (func == "AskUser") { > - Report::Message (_("There is nothing to set.")); > + string chosen_id = param["chosen_id"]:""; > + > + // toggle the download mode status > + if (chosen_id == Wagon::GetDownloadModeLink()) > + { > + PackageInstallation::SetDownloadInAdvance(!PackageInstallation::DownloadInAdvance()); > + } > + else > + { > + Report::Message (_("There is nothing to set.")); > + } > + > ret = $[ "workflow_sequence" : `next ]; > > } else if (func == "Description") { > > Modified: trunk/wagon/src/modules/Wagon.ycp > URL: http://svn.opensuse.org/viewcvs/yast/trunk/wagon/src/modules/Wagon.ycp?rev=… > ============================================================================== > --- trunk/wagon/src/modules/Wagon.ycp (original) > +++ trunk/wagon/src/modules/Wagon.ycp Tue Jun 14 14:00:22 2011 > @@ -31,6 +31,8 @@ > import "Update"; > import "FileUtils"; > import "String"; > + import "Packages"; > + import "PackageInstallation"; > > boolean running_by_applet = false; > > @@ -75,6 +77,13 @@ > return update_workflow_type; > } > > + const string download_mode_link = "wagon-download_in_advance"; > + > + global define string GetDownloadModeLink() > + { > + return download_mode_link; > + } > + > string migration_method = nil; > > global string migration_method_file = sformat ("%1/wagon_migration_method", Directory::vardir); > @@ -379,6 +388,68 @@ > return true; > } > > + string FindMountPoint(string dir, list<string> dirs) > + { > + while (dir != nil && dir != "" && !contains(dirs, dir)) > + { > + // strip the last path component and try it again > + list<string> comps = splitstring(dir, "/"); > + comps = remove(comps, size(comps) - 1); > + dir = mergestring(comps, "/"); > + } > + > + return dir; > + } ^ I *think* that this function fails if it should return "/", returning "" instead. Unit tests? A descriptive comment for the function, mentioning the corner cases? > + > + map<string, any> CheckDownloadSpace() > + { > + map<string, list> du = Pkg::TargetGetDU(); > + list<string> mounts = maplist(string dir, list info, du, {return dir;}); > + > + map<string,any> zconfig = Pkg::ZConfig(); > + string pkg_path = zconfig["repo_packages_path"]:""; > + > + string packages_mount = FindMountPoint(pkg_path, mounts); > + y2milestone("Packages will we downloaded to mountpoint %1", packages_mount); > + > + // download size in bytes > + integer download_size = Packages::CountSizeToBeDownloaded(); > + y2milestone("Size of packages to download: %1MB", download_size >> 20); > + > + // du contains maps: $[ "dir" : [ total, used, pkgusage, readonly ], .... ] > + integer after_install = du[packages_mount, 2]:0; > + integer total = du[packages_mount, 0]:0; > + > + symbol result = `ok; > + string message = ""; > + > + if (after_install + download_size < total) > + { > + result = `error; > + message = "Not enough free space"; _() missing? > + y2error("Not enough free space for download in advance upgrade"); > + } > + else if (after_install + download_size < total - 100<<20) > + { > + result = `warning; > + message = "Not enough free space"; _() ? > + y2error("Not enough free space for download in advance upgrade"); good luck with distinguishing the two situations in y2log some months later ;-) > + } > + > + return $[ "result" : result, "message" : message ]; > + } > + > + global void ProposeDownloadMode() > + { > + if (PackageInstallation::DownloadInAdvance() == nil) > + { > + map<string, any> dwspace = CheckDownloadSpace(); > + > + PackageInstallation::SetDownloadInAdvance(dwspace["result"]:nil == `ok); > + y2milestone("Proposed download in advance mode: %1", PackageInstallation::DownloadInAdvance()); > + } > + } > + > global map <string,any> MinimizeProductMap (map <string,any> product) { > if (haskey (product, "license")) product["license"] = "..."; > if (haskey (product, "description")) product["description"] = "..."; > @@ -510,9 +581,14 @@ > > ret = "<ul>\n" + ret + "</ul>\n"; > > + ret = ret + "<ul><li>\n" + _("Download all packages before upgrade: ") + > + sformat("<a href=\"%1\">%2</a>", download_mode_link, (PackageInstallation::DownloadInAdvance() ? _("Enabled") : _("Disabled"))) > + + "</li></ul>\n"; > + > map <string, any> summary = $[ > "preformatted_proposal" : ret, > - // help text > + "links" : [ download_mode_link ], > + // help text, TODO FIXME: replace the inner by WTF? Is this a broken text unfixable because it is translated already? OK, but this is the trunk. > "help" : _("To change the update settings, go to Packages Proposal section."), > ]; > > > Modified: trunk/wagon/yast2-wagon.spec.in > URL: http://svn.opensuse.org/viewcvs/yast/trunk/wagon/yast2-wagon.spec.in?rev=64… > ============================================================================== > --- trunk/wagon/yast2-wagon.spec.in (original) > +++ trunk/wagon/yast2-wagon.spec.in Tue Jun 14 14:00:22 2011 > @@ -10,7 +10,8 @@ > Requires: yast2-pkg-bindings >= 2.19.1 > > # Called in proposal and in code > -Requires: yast2-packager yast2-add-on > +Requires: yast2-packager >= 2.21.2 > +Requires: yast2-add-on > > # Counting packages directly in packages proposal (BNC #573482) > Requires: yast2-update >= 2.18.7 > > -- > To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org > For additional commands, e-mail: yast-commit+help(a)opensuse.org > -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu

1 0

[yast-devel] Re: [yast-commit] r64312 - /branches/SuSE-Code-11-SP2-Branch/ldap-server/src/agent/SlapdConfigAgent.cc
by Martin Vidner 14 Jun '11

14 Jun '11

On Fri, Jun 10, 2011 at 09:08:26AM -0000, rhafer(a)svn2.opensuse.org wrote: > Author: rhafer > Date: Fri Jun 10 11:08:25 2011 > New Revision: 64312 > > URL: http://svn.opensuse.org/viewcvs/yast?rev=64312&view=rev > Log: > fixed return value for undefined update referral > > Modified: > branches/SuSE-Code-11-SP2-Branch/ldap-server/src/agent/SlapdConfigAgent.cc > > Modified: branches/SuSE-Code-11-SP2-Branch/ldap-server/src/agent/SlapdConfigAgent.cc > URL: http://svn.opensuse.org/viewcvs/yast/branches/SuSE-Code-11-SP2-Branch/ldap-… > ============================================================================== > --- branches/SuSE-Code-11-SP2-Branch/ldap-server/src/agent/SlapdConfigAgent.cc (original) > +++ branches/SuSE-Code-11-SP2-Branch/ldap-server/src/agent/SlapdConfigAgent.cc Fri Jun 10 11:08:25 2011 > @@ -961,10 +961,7 @@ > resMap.add( YCPString("target"), YCPString( updateUrl.getHost() ) ); > resMap.add( YCPString("port"), YCPInteger( updateUrl.getPort() ) ); > } > - else > - { > - resMap.add( YCPString("updateref"), YCPMap() ); > - } > + resMap = YCPNull(); > return resMap; > } This seems wrong, you're overwriting the resMap from the "if" branch. -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu

2 1

[yast-devel] YaST SDK for SLE 11 SP2
by Josef Reidinger 14 Jun '11

14 Jun '11

Hi, I create SDK for development of YAST for SP2[0]. It helps to not mess your machine and also easier testing your module on SP1 machine, so you don't have problem with too much recent software. If you miss something just ping me. I welcome any comments, complains or questions. Pepa P.S. try checkout_yast_svn script for easy svn checkout P.P.S. - if your machine is public accessible don't forget to change password for root and tux user ( default is linux ) [0] http://susegallery.com/a/F0D5dp/josefs-sled-11-sp1-yast-sdk -- Josef Reidinger Appliance Toolkit team maintaining parts of webyast and SLMS author of rubygems - studio_api and net_observer (coauthor) -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 2

[yast-devel] Ruby Bindings: Examples
by Lukas Ocilka 13 Jun '11

13 Jun '11

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, I've just tried all the examples from http://svn.opensuse.org/svn/yast/trunk/ruby-bindings/examples/ruby/ and it seems that none of them work. At least not for me. What's the current status of this package? What's the status of calling Ruby from YCP and vice versa? Thanks in advance Lukas - -- Lukas Ocilka, Appliances Department, SUSE LINUX s.r.o. MD: Jeff Hawn, Jennifer Guild, Alena Hendrichova -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iD8DBQFN9f+MVSqMdRCqTiwRAuy0AKCP8eHxxr/9wpDL3k1m0qeQ1znzawCfROSf qqz2WGl4cQlUId/vGS2zzQg= =+b9F -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

2 2

[yast-devel] Re: [yast-commit] r64314 - in /branches/SuSE-Code-11-SP2-Branch/autoinstallation: package/autoyast2.changes src/include/io.ycp
by Lukas Ocilka 13 Jun '11

13 Jun '11

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Dne 10.6.2011 15:22, ug(a)svn2.opensuse.org napsal(a): > Author: ug > Date: Fri Jun 10 15:22:36 2011 > New Revision: 64315 > > Modified: > branches/SuSE-Code-11-SP2-Branch/autoinstallation/package/autoyast2.changes > branches/SuSE-Code-11-SP2-Branch/autoinstallation/src/include/io.ycp > > Modified: branches/SuSE-Code-11-SP2-Branch/autoinstallation/package/autoyast2.changes > URL: http://svn.opensuse.org/viewcvs/yast/branches/SuSE-Code-11-SP2-Branch/autoi… > ============================================================================== > --- branches/SuSE-Code-11-SP2-Branch/autoinstallation/package/autoyast2.changes (original) > +++ branches/SuSE-Code-11-SP2-Branch/autoinstallation/package/autoyast2.changes Fri Jun 10 15:22:36 2011 > @@ -1,10 +1,4 @@ > ------------------------------------------------------------------- > -Fri Jun 10 15:06:40 CEST 2011 - ug(a)suse.de > - > -- merged the code for autoyast=device and autoyast=usb to reduce > - redundancy and fix the "already mounted" bug for USB (bnc#565558) > - > -------------------------------------------------------------------- Just an idea, while you are refactoring... wouldn't it be better to move a particular schema-related code to functions instead of having it in one big function (287 lines long)? if ( Scheme == "http" || Scheme == "https" ) { return GetHTTP(...); } else if ( Scheme == "ftp" ) { return GetFTP(...); } else if (Scheme == "file") { return GetFile(...); } else if ... This was almost the first thing I had to do with the code in YaST Backup as it used looooong `if, else if` statements with even looooonger `while` loops. That made the code uneasy to understand and debug. I know that YCP is not an object-oriented language and that makes is harder but it can still be done with, for instance, pointers to variables. BTW, splitting into more functions makes it easier to test too. Bye Lukas - -- Lukas Ocilka, Appliances Department, SUSE LINUX s.r.o. MD: Jeff Hawn, Jennifer Guild, Alena Hendrichova -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iD8DBQFN9b43VSqMdRCqTiwRAgvlAKCEK42IoZ7YEkyg+8V6iFy4OsP/AgCdHIQp XWQisjCpvBmCsl0vj9igrxE= =Pw4a -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] GsoC Weekly Report - Separating libYUI
by N B Prashanth 11 Jun '11

11 Jun '11

Hi, I am attaching my GsoC weekly report along with this mail. It can also be found at nbprashanth.wordpress.org (http://nbprashanth.wordpress.com/2011/06/11/gsoc-report-2/) ------------------------------------------------------------- Hi. The last week was full of changes for libYUI. To start off, the packages are no longer being built locally and the build process is now handled by OBS. This makes libYUI available on a wide range of operating systems and architectures. Currently, the build at OBS is being done for Fedora 14/15 as well as Ubuntu 10.10/11.04 for both x86 and x86_64 architectures. Interested people can find the OBS repository at http://download.opensuse.org/repositories/home:/nbprashanth/. This means that the binaries will no longer be availalbe at the gitorious repository(gitorious.org/libyui). Secondly, the initial documentation for the library is hosted at http://doc.opensuse.org/projects/libyui/HEAD/. This documentation is subjected to frequent updates and will change regularly (weekly updates planned). Again, to avoid duplications, the gitorious repository will not contain the documentation anymore. People who test the new packages are requested to submit bug reports (here or at OBS) in order to help improve libYUI. ------------------------------------------------------------- -- Regards, N.B.Prashanth -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0

[yast-devel] GsoC Weekly Report - Separating libYUI
by N.B.Prashanth 11 Jun '11

11 Jun '11

Hi, I am attaching my GsoC weekly report along with this mail. It can also be found at nbprashanth.wordpress.org (http://nbprashanth.wordpress.com/2011/06/11/gsoc-report-2/) ------------------------------------------------------------- Hi. The last week was full of changes for libYUI. To start off, the packages are no longer being built locally and the build process is now handled by OBS. This makes libYUI available on a wide range of operating systems and architectures. Currently, the build at OBS is being done for Fedora 14/15 as well as Ubuntu 10.10/11.04 for both x86 and x86_64 architectures. Interested people can find the OBS repository at http://download.opensuse.org/repositories/home:/nbprashanth/. This means that the binaries will no longer be availalbe at the gitorious repository(gitorious.org/libyui). Secondly, the initial documentation for the library is hosted at http://doc.opensuse.org/projects/libyui/HEAD/. This documentation is subjected to frequent updates and will change regularly (weekly updates planned). Again, to avoid duplications, the gitorious repository will not contain the documentation anymore. People who test the new packages are requested to submit bug reports (here or at OBS) in order to help improve libYUI. ------------------------------------------------------------- -- Regards, N.B.Prashanth -- To unsubscribe, e-mail: yast-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-devel+help(a)opensuse.org

1 0