[opensuse-ruby] .gitignore in gems
I noticed that the rubygem-rainbows gem contains three .gitignore files, which cause rpmlint warnings. I'm guessing there are other gems out there with the same problem. Would it make sense to fix this by adding something like find $RPM_BUILD_ROOT -name .gitignore | xargs -n rm to /usr/lib/rpm/gem_install_wrapper.sh? The danger is that there might be an occasion where there was a real need for a gem rpm to include a .gitignore file. The alternatives are: - try to get the upstream gem fixed, or - do the same .gitignore removal in each .spec file, which is annoying and potentially repetitive. -- To unsubscribe, e-mail: opensuse-ruby+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-ruby+owner@opensuse.org
Adam Spiers (aspiers@suse.com) wrote:
I noticed that the rubygem-rainbows gem contains three .gitignore files, which cause rpmlint warnings. I'm guessing there are other gems out there with the same problem. Would it make sense to fix this by adding something like
find $RPM_BUILD_ROOT -name .gitignore | xargs -n rm
Sorry, I meant xargs -r not -n ... -- To unsubscribe, e-mail: opensuse-ruby+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-ruby+owner@opensuse.org
On 04.11.2012 19:39, Adam Spiers wrote:
I noticed that the rubygem-rainbows gem contains three .gitignore files, which cause rpmlint warnings. I'm guessing there are other gems out there with the same problem. Would it make sense to fix this by adding something like
find $RPM_BUILD_ROOT -name .gitignore | xargs -n rm
to /usr/lib/rpm/gem_install_wrapper.sh?
The danger is that there might be an occasion where there was a real need for a gem rpm to include a .gitignore file.
The alternatives are:
- try to get the upstream gem fixed, or
- do the same .gitignore removal in each .spec file, which is annoying and potentially repetitive.
As there are 241 gems that show that warning, I would say it's a good idea to centralize the fix. I can't think of a reason to keep the .gitignore in the installed gem. Greetings, Stephan -- To unsubscribe, e-mail: opensuse-ruby+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-ruby+owner@opensuse.org
On Mon, 05 Nov 2012 10:32:21 +0100
Stephan Kulow
On 04.11.2012 19:39, Adam Spiers wrote:
I noticed that the rubygem-rainbows gem contains three .gitignore files, which cause rpmlint warnings. I'm guessing there are other gems out there with the same problem. Would it make sense to fix this by adding something like
find $RPM_BUILD_ROOT -name .gitignore | xargs -n rm
to /usr/lib/rpm/gem_install_wrapper.sh?
The danger is that there might be an occasion where there was a real need for a gem rpm to include a .gitignore file.
The alternatives are:
- try to get the upstream gem fixed, or
- do the same .gitignore removal in each .spec file, which is annoying and potentially repetitive.
As there are 241 gems that show that warning, I would say it's a good idea to centralize the fix.
I can't think of a reason to keep the .gitignore in the installed gem.
Greetings, Stephan
Well, I know one gem, that have reason. It is gem with generator, that generate project and it generate also .gitignore which is just copyied from original destination (so no suffix), but I think it can be easy workarounded ( and gem is our own, so it is not problem to change it ). Josef -- To unsubscribe, e-mail: opensuse-ruby+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-ruby+owner@opensuse.org
On 05.11.2012 11:38, Josef Reidinger wrote:
Well, I know one gem, that have reason. It is gem with generator, that generate project and it generate also .gitignore which is just copyied from original destination (so no suffix), but I think it can be easy workarounded ( and gem is our own, so it is not problem to change it ). Josef
If there are cases, it makes sense to support them via export KEEP_GITIGNORE=1 %gem_install -f Greetings, Stephan -- To unsubscribe, e-mail: opensuse-ruby+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-ruby+owner@opensuse.org
Stephan Kulow (coolo@suse.de) wrote:
On 05.11.2012 11:38, Josef Reidinger wrote:
Well, I know one gem, that have reason. It is gem with generator, that generate project and it generate also .gitignore which is just copyied from original destination (so no suffix), but I think it can be easy workarounded ( and gem is our own, so it is not problem to change it ). Josef
If there are cases, it makes sense to support them via export KEEP_GITIGNORE=1 %gem_install -f
That sounds good. I will update /usr/lib/rpm/gem_install_wrapper.sh and generate a submitrequest for ruby19, but only if someone can answer the following: - Once I've built a new ruby19, how can I ensure that it is used locally by 'osc build' of a gem, to test my changes? - Which repository should I branch from / submitrequest to? - Why doesn't gem_install_wrapper.sh belong in ruby-common? Thanks, Adam -- To unsubscribe, e-mail: opensuse-ruby+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-ruby+owner@opensuse.org
On 05.11.2012 14:38, Adam Spiers wrote: No need to CC me on everything, as you may have found out already - I'm part of the list.
Stephan Kulow (coolo@suse.de) wrote:
On 05.11.2012 11:38, Josef Reidinger wrote:
Well, I know one gem, that have reason. It is gem with generator, that generate project and it generate also .gitignore which is just copyied from original destination (so no suffix), but I think it can be easy workarounded ( and gem is our own, so it is not problem to change it ). Josef
If there are cases, it makes sense to support them via export KEEP_GITIGNORE=1 %gem_install -f
That sounds good. I will update /usr/lib/rpm/gem_install_wrapper.sh and generate a submitrequest for ruby19, but only if someone can answer the following:
- Once I've built a new ruby19, how can I ensure that it is used locally by 'osc build' of a gem, to test my changes? osc build -p will do
- Which repository should I branch from / submitrequest to?
You should branch from openSUSE:Factory, which will then automatically do the right thing - and in the end you will submit to the devel project of it - devel:languages:ruby
- Why doesn't gem_install_wrapper.sh belong in ruby-common?
Mostly because ruby-1.8 already has one such file and ruby-common needs to work with it. Greetings, Stephan -- To unsubscribe, e-mail: opensuse-ruby+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-ruby+owner@opensuse.org
Stephan Kulow (coolo@suse.de) wrote:
On 05.11.2012 14:38, Adam Spiers wrote:
No need to CC me on everything, as you may have found out already - I'm part of the list.
OK :)
Stephan Kulow (coolo@suse.de) wrote:
On 05.11.2012 11:38, Josef Reidinger wrote:
Well, I know one gem, that have reason. It is gem with generator, that generate project and it generate also .gitignore which is just copyied from original destination (so no suffix), but I think it can be easy workarounded ( and gem is our own, so it is not problem to change it ). Josef
If there are cases, it makes sense to support them via export KEEP_GITIGNORE=1 %gem_install -f
That sounds good. I will update /usr/lib/rpm/gem_install_wrapper.sh and generate a submitrequest for ruby19, but only if someone can answer the following:
- Once I've built a new ruby19, how can I ensure that it is used locally by 'osc build' of a gem, to test my changes? osc build -p will do
- Which repository should I branch from / submitrequest to?
You should branch from openSUSE:Factory, which will then automatically do the right thing - and in the end you will submit to the devel project of it - devel:languages:ruby
- Why doesn't gem_install_wrapper.sh belong in ruby-common?
Mostly because ruby-1.8 already has one such file and ruby-common needs to work with it.
Thanks for the info. I'll give it a go. -- To unsubscribe, e-mail: opensuse-ruby+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-ruby+owner@opensuse.org
participants (3)
-
Adam Spiers
-
Josef Reidinger
-
Stephan Kulow