[Bug 21812] New: PM: Switch to registers (from AtomBIOS) for engine clock control
http://bugs.freedesktop.org/show_bug.cgi?id=21812 Summary: PM: Switch to registers (from AtomBIOS) for engine clock control Product: xorg Version: unspecified Platform: Other OS/Version: All Status: NEW Severity: enhancement Priority: low Component: Driver/radeonhd AssignedTo: lverhaegen@suse.de ReportedBy: zajec5@gmail.com QAContact: xorg-team@lists.x.org Currently we use AtomBIOS to control engine clock. Would be nice to RE or get from AMD registers needed to do the same without AtomBIOS. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ xorg-team mailing list xorg-team@lists.x.org http://lists.x.org/mailman/listinfo/xorg-team -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
http://bugs.freedesktop.org/show_bug.cgi?id=21812
--- Comment #1 from Rafał Miłecki
http://bugs.freedesktop.org/show_bug.cgi?id=21812
--- Comment #2 from Alex Deucher
http://bugs.freedesktop.org/show_bug.cgi?id=21812
--- Comment #3 from Rafał Miłecki
http://bugs.freedesktop.org/show_bug.cgi?id=21812
--- Comment #4 from Rafał Miłecki
You can look at the command table for SetEngineClock and see the algorithm and registers used to compute and set the engine pll. The AtomDis utility is useful for this.
I started with looking on GetEngineClock (should be easier). I can't understand that. $ ./atomdis 95C4.104D.9035.vga.rom c 30 | grep reg gives me 2 unique registers: reg[0180] and reg[01f5] # rhd_dump -r 0180,0180 01:00.0 && rhd_dump -r 01f4,01f4 01:00.0 gives me: 0x0180: 0x00000000 0x01F4: 0x00000000 So I have no idea how AtomBIOS can calculate that. It uses these 2 registers, but both are always zeroed for me. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ xorg-team mailing list xorg-team@lists.x.org http://lists.x.org/mailman/listinfo/xorg-team N�����r��y隊Z�u�'�߮�˛���m�)z{.��+�Z+i�b�*'jW(�f�vǦj)kiר�~��i�������
http://bugs.freedesktop.org/show_bug.cgi?id=21812
--- Comment #5 from Rafał Miłecki
http://bugs.freedesktop.org/show_bug.cgi?id=21812
--- Comment #6 from Matthias Hopf
http://bugs.freedesktop.org/show_bug.cgi?id=21812
--- Comment #7 from Matthias Hopf
http://bugs.freedesktop.org/show_bug.cgi?id=21812
--- Comment #8 from Yang Zhao
I wouldn't invest too much time in that - I would assume that the power logic is something that may be changed from chip to chip subtly. It's not that we will be changing the frequency on a millisecond basis.
Ditto. Remember that it's still the driver doing the actual register manipulation; AtomBIOS just tells it what to do. If speed and/or clarity is identified to be an issue, rewriting the AtomBIOS implementation in radeonhd is perhaps a better way. So far, I don't think anyone's considered this to be worth the effort. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ xorg-team mailing list xorg-team@lists.x.org http://lists.x.org/mailman/listinfo/xorg-team -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
http://bugs.freedesktop.org/show_bug.cgi?id=21812
--- Comment #9 from Rafał Miłecki
http://bugs.freedesktop.org/show_bug.cgi?id=21812
--- Comment #10 from Matthias Hopf
Whatever you do with these patches, invested time won't be wasted. I'm doing that to understand the way driver works and slowly I'm getting clue on that :)
I agree that this is a good way to understand the AtomBIOS inner workings, and we definitely could need another guy understanding it - sometimes you just need to know(TM) what actually happens to make something work :-)
I decided to publish my work because I thought you prefer to use registers rather than AtomBIOS in radeonhd... I based my opinion on using registers for PLL/CRTC/etc by radeonhd.
Given that AtomBIOS works actually pretty well this is not a *strong* preference now. Still, in quite some regions direct coding is preferred. Power management however is something that can easily change subtly between chips (e.g. delays between register accesses or register access order may change). In these cases using AtomBIOS might be a better idea, however, we don't know yet whether we can do everything we want to with AtomBIOS alone. So your analysis might come in handy later on. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ xorg-team mailing list xorg-team@lists.x.org http://lists.x.org/mailman/listinfo/xorg-team -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
https://bugs.freedesktop.org/show_bug.cgi?id=21812
--- Comment #11 from Jeremy Huddleston
https://bugs.freedesktop.org/show_bug.cgi?id=21812
--- Comment #12 from Rafał Miłecki
Does this issue occur with the preferred ati driver (xf86-vide-ati)? If so, please move this to the Driver/Radeon component.
Sure, radeon uses AtomBIOS as often as possible.
Development of radeonhd has pretty much halted and development focus is on the ati driver. Please see http://www.x.org/wiki/radeonhd
I know very well.
If the issue does not exist in the ati driver (or if there is no response to this message), this bug will be closed as WONTFIX unless someone contributes a patch.
Have you read that bug reports at all? The ones you were replying recently massively. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. _______________________________________________ xorg-team mailing list xorg-team@lists.x.org http://lists.x.org/mailman/listinfo/xorg-team
participants (1)
-
bugzilla-daemon@freedesktop.org