Reporting from xf86-video-radeonhd: Radeon HD video driver Please visit: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd Or get your own copy by using: git-clone git://anongit.freedesktop.org/xorg/driver/xf86-video-radeonhd 36 commits against master at b6b1c280...: src/rhd.h | 2 src/rhd_atombios.c | 28 +++ src/rhd_atombios.h | 25 ++- src/rhd_crtc.c | 237 ++++++++++++++++++++++++++++---- src/rhd_crtc.h | 27 ++- src/rhd_driver.c | 128 +++++++++++++---- src/rhd_edid.c | 2 src/rhd_modes.c | 381 ++++++++++++++++++++++++++++++++++++++++------------- src/rhd_modes.h | 5 src/rhd_monitor.c | 15 +- src/rhd_monitor.h | 1 src/rhd_randr.c | 131 ++++++++++++++---- src/rhd_regs.h | 21 ++ 13 files changed, 793 insertions(+), 210 deletions(-) commit 4f3d627795ab4532850de1709d04e5005c6be59c Author: Egbert Eich Date: Tue May 27 01:07:51 2008 +0200 Access correct NB registers for MC index/data on RS780. This code still needs testing therefore it's not enabled, yet. diffstat: src/rhd_crtc.c | 1 - src/rhd_driver.c | 25 ++++++++++++++++++++++--- src/rhd_regs.h | 18 ++++++++++++++++++ 3 files changed, 40 insertions(+), 4 deletions(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit 9d9ac5d6f06c3b0aa35153dc577a44a824a64d91 Author: Egbert Eich Date: Wed May 14 21:54:13 2008 +0200 Supply a pScrn->memPhysBase address. diffstat: src/rhd_driver.c | 2 ++ 1 file changed, 2 insertions(+) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit 9c6fd8b2a55d63e9b6d695415945b354a0c901d2 Author: Egbert Eich Date: Mon May 26 21:25:37 2008 +0200 Under RandR print modeline of mode we scale from when verbosity > 2. diffstat: src/rhd_randr.c | 4 ++++ 1 file changed, 4 insertions(+) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit 3d2c15e8269bb94b3770690eb6c0f8e78c91bfb6 Author: Egbert Eich Date: Mon May 26 19:56:13 2008 +0200 Map FB memory directly on RS780. diffstat: src/rhd_driver.c | 3 +++ src/rhd_regs.h | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit 83023fc93df4039eea73cbce1054147cb043214e Author: Egbert Eich Date: Mon May 26 19:16:19 2008 +0200 Delete spurious leftovers from rebasing scaler support. diffstat: src/rhd_crtc.c | 24 ------------------------ 1 file changed, 24 deletions(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit 71de7a704d0b8dadadba437404c223556841ef41 Author: Egbert Eich Date: Mon May 26 19:05:43 2008 +0200 Consolidate different mode validation functions. For the ScaledTo mode don't validate scaling (which will be done later once the scaled from mode is known) and don't validate against the FB (as this depends on the mode that determines the resolution). diffstat: src/rhd_modes.c | 145 ++++++++++++++++++++-------------------------------- src/rhd_randr.c | 3 - 2 files changed, 58 insertions(+), 90 deletions(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit f357819fcc0edc64c9090380c3903e164f0b4d4c Author: Egbert Eich Date: Thu May 15 09:21:05 2008 +0200 Always assume the rhdOutput struct in rhdRROutputModeFixup() has its CRTC member set. diffstat: src/rhd_randr.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit f36d8b6a115083bc2280f861a47c0d132fa86d27 Author: Egbert Eich Date: Fri May 16 17:01:29 2008 +0200 Fix heuristic for RR mode validation to find out about scaled mode. Also always attach scaledTo mode to rhd CRTC struct so we don't need to pass it around. The scaledTo mode is only used when the crtc specific scaling validation is available. Thus we can attach it there. Move collection of ScaledToMode to rhdRROutputGetModes(). This way the scaled to mode will be redetermined whenever a the output is reprobed. diffstat: src/rhd_modes.c | 21 ++++++--------------- src/rhd_modes.h | 2 +- src/rhd_randr.c | 50 ++++++++++++++++++++++++-------------------------- 3 files changed, 31 insertions(+), 42 deletions(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit d09223bdda031503fa3ea04324fe85bf4cb73478 Author: Egbert Eich Date: Fri May 16 15:38:58 2008 +0200 Make sure to use the right mode for validation. There was a mix up of scaledFrom and scaledTo modes in the validation routines. diffstat: src/rhd_modes.c | 34 +++++++++++++--------------------- src/rhd_randr.c | 7 +++++-- 2 files changed, 18 insertions(+), 23 deletions(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit 7fd3760ec6144dd3d5c2e69d497454d949b48b7c Author: Egbert Eich Date: Sun May 4 15:03:32 2008 +0200 Move mode validation after scaler validation. This groups all validations that deal with actual timing parameters together. These validations affect the mode whose timing parameters are used ie the one that is set for the display. All validations which take place before scaler validation deal with fb parameters, thus deal with the mode which we scale from. In the situation where we use scaling the display mode is validated once and before any other mode list validation takes place. When the mode list is validated only the modes from which we scale from are only validated against fb and the scaler as those modes have no influence on the actual timing. diffstat: src/rhd_modes.c | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit cb1f495c13433a4670758c3621da07eea4521965 Author: Egbert Eich Date: Sun May 4 14:07:50 2008 +0200 Changed type of 'Type' variable for scaling from CARD32 to enum rhdCrtcScaleType. The scaling types used to be defines however those are dealt with entirely by a dump preprocessor. Enums have the benefit that they enjoy full lexical and sematic checking by the compiler. A lot of common errors can be caught and avoided that way. diffstat: src/rhd.h | 2 +- src/rhd_crtc.c | 51 +++++++++++++++++++++++++++++++++++++++++++-------- src/rhd_crtc.h | 27 ++++++++++++++++----------- src/rhd_driver.c | 24 +++--------------------- src/rhd_modes.c | 2 +- src/rhd_randr.c | 2 +- 6 files changed, 65 insertions(+), 43 deletions(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit 2d7834d22d894cc349acd76755041a952b7502a7 Author: Egbert Eich Date: Sun May 4 14:11:09 2008 +0200 Add support for keeping the aspect ratio when scaling. diffstat: src/rhd_crtc.c | 33 ++++++++++++++++++++++++++++++++- src/rhd_crtc.h | 9 +++++---- src/rhd_driver.c | 2 ++ src/rhd_modes.c | 8 ++++++++ 4 files changed, 47 insertions(+), 5 deletions(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit fcaa97bed09dfa9d99e453cd6581dcf061337099 Author: Egbert Eich Date: Sat May 3 11:17:51 2008 +0200 More naming convention fixes: nativeMode -> NativeMode. diffstat: src/rhd_driver.c | 4 ++-- src/rhd_edid.c | 2 +- src/rhd_monitor.c | 10 +++++----- src/rhd_monitor.h | 2 +- src/rhd_randr.c | 2 +- 5 files changed, 10 insertions(+), 10 deletions(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit 390b4fd42a23b67c0cf97acba6da7b066c2b156c Author: Egbert Eich Date: Sat May 3 10:45:32 2008 +0200 Adhere to naming conventions: fix naming of overscan struct. diffstat: src/rhd_crtc.c | 74 ++++++++++++++++++++++++++--------------------------- 1 file changed, 37 insertions(+), 37 deletions(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit e7e99ad3025c255cf41fc108448b00f3302a695c Author: Egbert Eich Date: Sat May 3 10:39:51 2008 +0200 Renamed ScaledMode to ScaledToMode. The name change should make clear that this is the mode we scale to ie the mode set on the CRTC (native mode of the display). diffstat: src/rhd_crtc.c | 20 ++++++++++++-------- src/rhd_crtc.h | 6 +++--- src/rhd_driver.c | 16 ++++++++-------- src/rhd_modes.c | 16 ++++++++-------- src/rhd_modes.h | 2 +- src/rhd_randr.c | 24 ++++++++++++------------ 6 files changed, 44 insertions(+), 40 deletions(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit c11724baa40a424af85db7e5f368a729fb0ea9d4 Author: Egbert Eich Date: Sat May 3 10:04:53 2008 +0200 Don't add CRTC overscan to Dx_MODE overscan. Dx_MODE overscan is for determining the destination window for scaling. It seems to be wrong to include a display overscan into this calculation. diffstat: src/rhd_crtc.c | 5 ----- 1 file changed, 5 deletions(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit 13146498655a0e7e86eff4e63d5853b04d865a20 Author: Egbert Eich Date: Sat May 3 10:02:39 2008 +0200 Fix non-AtomBIOS based scaling. diffstat: src/rhd_crtc.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit e0955028bea078dc3928e2896a03070402ab091b Author: Egbert Eich Date: Thu May 1 19:24:00 2008 +0200 Added more validations for modes that we scale from. Modes we scale from need to be validated against the FB and the scaler. This commit also clarifies the names of the validation funcitons. diffstat: src/rhd_driver.c | 2 - src/rhd_modes.c | 83 +++++++++++++++++++++++++++++++++++++++++---------- src/rhd_modes.h | 4 +- src/rhd_randr.c | 4 +- 4 files changed, 72 insertions(+), 21 deletions(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit ac6b2c7829c9f46721c8a43246cd69e32a67e9ae Author: Egbert Eich Date: Thu May 1 13:22:09 2008 +0200 Make scale type configurable thru an option. diffstat: src/rhd.h | 1 + src/rhd_crtc.h | 1 + src/rhd_driver.c | 26 +++++++++++++++++++++++--- src/rhd_modes.c | 4 ++-- src/rhd_randr.c | 2 +- 5 files changed, 28 insertions(+), 6 deletions(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit c6d8f4a4b215bdf4cdc012bec227a44f9d77b93e Author: Egbert Eich Date: Thu May 1 12:59:11 2008 +0200 Add validation for overscan. Although overscan area ranges on radeonHD are huge we should check if they are not exceeded. diffstat: src/rhd_crtc.c | 123 ++++++++++++++++++++++++++++++++++------------------- 1 file changed, 79 insertions(+), 44 deletions(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit c90f318d1f0c69ec743db08a61d25b00adadb0a3 Author: Egbert Eich Date: Thu May 1 17:59:43 2008 +0200 Move validation of scaled mode to RandrPreInit(). The scaled mode needs to be validated before we use it for the first time. Unfortunately at this stage we cannot validate against the CRTC yet. Unfortunately when we can do this it's already too late. diffstat: src/rhd_driver.c | 6 +-- src/rhd_modes.c | 81 +++++++++++++++++++++++++++++++++++++++------------ src/rhd_modes.h | 3 + src/rhd_randr.c | 43 +++++++++++++++++++++------ 4 files changed, 101 insertions(+), 32 deletions(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit 21f0125de2860a3ef2b2c890ab914f33c9014850 Author: Egbert Eich Date: Thu May 1 09:20:22 2008 +0200 Move viewport size validation to the scaler validation callback. We don't validate the scaled up/down mode against the DxModeValid() as non of its timing parameters are used. Viewport size (ie H/VDisplay) are not really considered timing parameters. diffstat: src/rhd_crtc.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit 6c3c549e0b21df3e86241d4bfb91e64d14d963e6 Author: Egbert Eich Date: Thu May 1 09:02:39 2008 +0200 Add a per monitor native mode. The native mode should be the mode that coincides with the native resolution of a monitor. For an LCD this would be the number of horizontal and vertical pixel. On panels we assume it's either the higest resolution in an EDID block or the panel mode supplied by AtomBIOS. For any other monitor that can do DDC it's the first detailed timing if the monitor has the preferred mode flag bit set. diffstat: src/rhd_driver.c | 19 ++++++------------- src/rhd_edid.c | 2 ++ src/rhd_monitor.c | 7 +++++-- src/rhd_monitor.h | 1 + src/rhd_randr.c | 32 ++++++++++---------------------- 5 files changed, 24 insertions(+), 37 deletions(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit 605ad46ca7aa057ec7e473871ed1ac1e237074e4 Author: Egbert Eich Date: Thu May 1 08:59:42 2008 +0200 'Tweak' frame rate of synthesized mode. Chances are that the native mode of a display is a CVT mode with 60 Hz. This will make RandR share the CRTC which is undesireable for scaling. This we 'tweak' the frequency to be slightly higher. Don't tell me it's ugly - I know this already. diffstat: src/rhd_modes.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit 915b74bd18aef28de7ce3e415e2c158c494653ba Author: Egbert Eich Date: Thu May 1 08:31:44 2008 +0200 Move RHDRRMonitorInit() to rhd_randr.c. This function isn't called from anywhere else, also it doesn't reference anything private to rhd_monitor.c. diffstat: src/rhd_monitor.c | 14 -------------- src/rhd_monitor.h | 1 - src/rhd_randr.c | 14 ++++++++++++++ 3 files changed, 14 insertions(+), 15 deletions(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit 4399b42abb94b559c42116ef55ed0bb9ff8a6462 Author: Egbert Eich Date: Thu May 1 08:27:20 2008 +0200 Use AtomBIOS for scaling when available. diffstat: src/rhd_atombios.c | 28 +++++++++++++++++++++++++--- src/rhd_atombios.h | 25 ++++++++++++++++++------- src/rhd_crtc.c | 32 ++++++++++++++++++++++++++++++++ 3 files changed, 75 insertions(+), 10 deletions(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit b86fb6c08f03afd6d3f14ac8c87bfdad2e5965a3 Author: Egbert Eich Date: Thu May 1 08:25:32 2008 +0200 Set RandR scale mode to expand not center. diffstat: src/rhd_randr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit dac9a8d86fce70d139524a6a0f6002751f27ccaf Author: Egbert Eich Date: Thu May 1 08:22:14 2008 +0200 Roll up loop. Let the compiler unroll the loop. Once the code becomes longer unrolled loops become messy, so let the compiler do this for you. diffstat: src/rhd_driver.c | 56 ++++++++++++++++++--------------------------------- 1 file changed, 20 insertions(+), 36 deletions(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit f5f16354574659304553faf392337b05f8cf81b1 Author: Egbert Eich Date: Thu May 1 08:12:23 2008 +0200 Fix overscan calculation. Woops, the order of subtraction was wrong. diffstat: src/rhd_crtc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit 10c4cf9de915fa0ecefe099be56e74e8c0ad4ab2 Author: Egbert Eich Date: Wed Apr 30 14:11:53 2008 +0200 Attempt to fail modes if scaled mode is invalid. Unfortunately it has no effect if we fail a mode in rhdRROutputModeFixup(). Instead we need to validate this mode earlier (before rhdRROutputModeValid() is called and add it to the rhdRandrOutputRec. From there we can pick it to create the timing mode in rhdRROutputModeFixup() and pass it as an additional argument to RHDRRModeFixup(). diffstat: src/rhd_randr.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit 1299136fe6e8865942570560b3571bdbc4a9805a Author: Egbert Eich Date: Wed Apr 30 13:34:27 2008 +0200 Simplify and consolidate mode scaling. This makes handling and validation of scaled modes less intrusive: - scaling isn't directly a monitor property. In principle we can scale for any device. Thus we create a central policy function that decides based on monitor and connector information (currently). - In the non-RandR case we use the ScaledMode entry in the Crtc structure to identify if a mode is scaled or not. This value of this entry depends on the policy and the availability of a valid native resolution mode. The ScaledMode is obtained and validated before any other mode validation takes place. This is part of the layout selection process. If a scaledMode is available we only validate other modes against this one in the scaler validation as this mode controls the full timing. - In the RandR case we don't have access to the full mode list. Thus we synthesize modes from well known resolutions. Our outputFixup() code handles the validation much the same way as it is done in the non-RandR case. diffstat: src/rhd.h | 1 src/rhd_driver.c | 56 +++++++++++++++++++++++++---- src/rhd_modes.c | 95 ++++++++++++++++++++++++-------------------------- src/rhd_modes.h | 1 src/rhd_monitor.c | 35 ------------------ src/rhd_monitor.h | 2 - src/rhd_randr.c | 25 +++++++------ 7 files changed, 113 insertions(+), 102 deletions(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit b91804cde474cd87dc5686474b673132b3d1b83a Author: Egbert Eich Date: Tue Apr 29 23:36:19 2008 +0200 Add scaler support for the Non-RandR case. ATM this is a minimal support. The modes for the two CRTCs are not handled separately. diffstat: src/rhd_driver.c | 27 +++++++++++++---- src/rhd_modes.c | 76 +++++++++++++++++++++++++++++++++++++++++++------- src/rhd_monitor.c | 29 +++++++++++++++++++ src/rhd_monitor.h | 1 4 files changed, 117 insertions(+), 16 deletions(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit 70c4d610518d566561c25b5e049caba2a654a06c Author: Egbert Eich Date: Tue Apr 29 18:04:56 2008 +0200 Integrate mode scaling for fixed size displays into RandR. diffstat: src/rhd_randr.c | 85 +++++++++++++++++++++++++++++++++++++++------------- 1 file changed, 64 insertions(+), 21 deletions(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit 52d38428074f7704ffad94d8181010fa810e6d37 Author: Egbert Eich Date: Tue Apr 29 17:57:25 2008 +0200 Fix ScalerSet to calculate overscan correctly. hould one of the target dimensions be greater than the size of the native mode this code automatically picks scaling (instead of centering). diffstat: src/rhd_crtc.c | 93 +++++++++++++++++++++++++++++++++++++++++++---------- 1 file changed, 77 insertions(+), 16 deletions(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit a3b6e284aefaa05e421304c28f7c30c079a3a4fa Author: Egbert Eich Date: Tue Apr 29 17:55:27 2008 +0200 Add syntesized CVT modes to mode list for scaling. For RandR we need to synthesize modes for scaling as there is no way to obtain the full mode pool. We take a list of well known display resolutions and generate CVT mode lines from them. This is mainly done so that those modes can pass validation as we only need HDisplay and VDisplay from these. diffstat: src/rhd_modes.c | 57 ++++++++++++++++++++++++++++++++++++++++++++++++++ src/rhd_modes.h | 1 src/rhd_monitor.c | 22 ++++++++++++++++--- src/rhd_monitor.h | 1 4 files changed, 78 insertions(+), 3 deletions(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... commit 1954d0461fc75ad212111141c428f8c00e471954 Author: Egbert Eich Date: Tue Apr 29 17:51:52 2008 +0200 Add support for scaled video modes. Here mode validation will be done differently depending if we validate an unscaled or a mode that is to be scaled. From the mode that is to be scaled to a different display resolution we only need the viewport size, thus we only need to validate it against the scaler. Finding the true display mode to validate against is a little trickier: we look for the monitor that is to be attached and pick the preferred mode. diffstat: src/rhd_modes.c | 149 ++++++++++++++++++++++++++++++-------------------- src/rhd_monitor.c | 4 + src/rhd_monitor.h | 1 3 files changed, 95 insertions(+), 59 deletions(-) gitweb url: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=commit;h=... -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org