xf86-video-radeonhd:master: 1 commit(s)
Reporting from xf86-video-radeonhd: Radeon HD video driver
Please visit:
http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd
Or get your own copy by using:
git-clone git://anongit.freedesktop.org/xorg/driver/xf86-video-radeonhd
Commit against master at ae41ab2f...:
commit b7a50a6f00bb6d207f5240f00cf83fbbd56bbf60
Author: Hans Ulrich Niedermann
Commit against master at ae41ab2f...: commit b7a50a6f00bb6d207f5240f00cf83fbbd56bbf60 Author: Hans Ulrich Niedermann
Date: Fri Sep 18 23:23:32 2009 +0200 Fix RHDRegWrite macro invocation breakage
This appears to be an obvious fix to a bug introduced with bab7c5f9. Neither ignoring the blue component nor discarding the calculation does made sense to me, and the obvious explanation for that would be a misplaced parenthesis.
diffstat: src/rhd_lut.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Apparently, the MMIO_OUT32 macro (which RHDRegWrite maps to) is defined differently on ppc than on i386 and x86_64. So when building a package for Fedora on ppc, I got the following error: rhd_lut.c: In function 'rhdLUTSetRows': rhd_lut.c:193: error: void value not ignored as it ought to be No idea whether the i386/x86_64 definition or the ppc definition is broken, but something is fishy here. Anyway, this fix appeared obvious: --- a/src/rhd_lut.c +++ b/src/rhd_lut.c @@ -191,7 +191,7 @@ rhdLUTSetRows(struct rhdLUT *LUT, int numColors, int *indices, LOCO *colors) index = indices[i]; RHDRegWrite(LUT, DC_LUT_RW_INDEX, index); RHDRegWrite(LUT, DC_LUT_30_COLOR, - (colors[index].red << 20) | (colors[index].green) << 10) | (colors[index].blue); + (colors[index].red << 20) | (colors[index].green << 10) | (colors[index].blue)); } } -- Hans Ulrich Niedermann -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
2009/9/18 Hans Ulrich Niedermann
--- a/src/rhd_lut.c +++ b/src/rhd_lut.c @@ -191,7 +191,7 @@ rhdLUTSetRows(struct rhdLUT *LUT, int numColors, int *indices, LOCO *colors) index = indices[i]; RHDRegWrite(LUT, DC_LUT_RW_INDEX, index); RHDRegWrite(LUT, DC_LUT_30_COLOR, - (colors[index].red << 20) | (colors[index].green) << 10) | (colors[index].blue); + (colors[index].red << 20) | (colors[index].green << 10) | (colors[index].blue)); } }
Oops, typo on my part. Thanks for the fix. -- Yang Zhao http://yangman.ca -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
participants (3)
-
Hans Ulrich Niedermann
-
ndim@kemper.freedesktop.org
-
Yang Zhao