Patch to make radeonhd work with latest xserver git.
I noticed a few days ago that the radeonhd driver does not compile with
the latest xserver git. After reviewing some of the changeslogs, it seems
that xserver repository has removed 2 files (wrappers) that the radeonhd
repository needs to compile. I have added a patch that will allow the
radeonhd driver compile with the latest xserver.
Also a few weeks ago, the radeonhd driver had some patches that finally
allowed me to use my DVI out on my Radeon X1600Pro card (RV530) but some
change around 1 or 2 weeks ago has finally prevented it from working
again. :(
diff -uNr xf86-video-radeonhd-original/src/rhd_atombios.c xf86-video-radeonhd/src/rhd_atombios.c
--- xf86-video-radeonhd-original/src/rhd_atombios.c 2007-12-09 20:54:45.000000000 -0600
+++ xf86-video-radeonhd/src/rhd_atombios.c 2007-12-09 20:56:41.000000000 -0600
@@ -28,7 +28,7 @@
#endif
#include "xf86.h"
#include "xf86_OSproc.h"
-#include "xf86_ansic.h"
+#include
On Dec 10, 07 10:42:56 -0600, raiden@server.boros.com wrote:
I noticed a few days ago that the radeonhd driver does not compile with the latest xserver git. After reviewing some of the changeslogs, it seems that xserver repository has removed 2 files (wrappers) that the radeonhd repository needs to compile. I have added a patch that will allow the radeonhd driver compile with the latest xserver.
@@ -28,7 +28,7 @@ #endif #include "xf86.h" #include "xf86_OSproc.h" -#include "xf86_ansic.h" +#include
#include "xf86Pci.h" #include "edid.h" #include "rhd.h"
Uh-oh. Not again the ansi compatibility layer :-( Any ideas, Egbert?
Also a few weeks ago, the radeonhd driver had some patches that finally allowed me to use my DVI out on my Radeon X1600Pro card (RV530) but some change around 1 or 2 weeks ago has finally prevented it from working again.
Are you able to git-bisect this?
Matthias
--
Matthias Hopf
On Mon, Dec 10, 2007 at 06:49:20PM +0100, Matthias Hopf wrote:
On Dec 10, 07 10:42:56 -0600, raiden@server.boros.com wrote:
I noticed a few days ago that the radeonhd driver does not compile with the latest xserver git. After reviewing some of the changeslogs, it seems that xserver repository has removed 2 files (wrappers) that the radeonhd repository needs to compile. I have added a patch that will allow the radeonhd driver compile with the latest xserver.
@@ -28,7 +28,7 @@ #endif #include "xf86.h" #include "xf86_OSproc.h" -#include "xf86_ansic.h" +#include
#include "xf86Pci.h" #include "edid.h" #include "rhd.h" Uh-oh. Not again the ansi compatibility layer :-( Any ideas, Egbert?
What's there seems to be correct. Adam Jackson threw out what remained of libcwrapper altogether a week or so ago.
Also a few weeks ago, the radeonhd driver had some patches that finally allowed me to use my DVI out on my Radeon X1600Pro card (RV530) but some change around 1 or 2 weeks ago has finally prevented it from working again.
Are you able to git-bisect this?
Maybe related to my LVTMA work of that time? Luc Verhaegen. SUSE/Novell X Driver Developer. -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
On Dec 10, 07 19:11:08 +0100, Luc Verhaegen wrote:
Also a few weeks ago, the radeonhd driver had some patches that finally allowed me to use my DVI out on my Radeon X1600Pro card (RV530) but some change around 1 or 2 weeks ago has finally prevented it from working again.
Are you able to git-bisect this?
Maybe related to my LVTMA work of that time?
Could also be HPD related...
Matthias
--
Matthias Hopf
On Mon, Dec 10, 2007 at 10:42:56AM -0600, raiden@server.boros.com wrote:
I noticed a few days ago that the radeonhd driver does not compile with the latest xserver git. After reviewing some of the changeslogs, it seems that xserver repository has removed 2 files (wrappers) that the radeonhd repository needs to compile. I have added a patch that will allow the radeonhd driver compile with the latest xserver.
Also a few weeks ago, the radeonhd driver had some patches that finally allowed me to use my DVI out on my Radeon X1600Pro card (RV530) but some change around 1 or 2 weeks ago has finally prevented it from working again. :(
Attached is an improved version which also compiles against 7.0.0. 6.8.2 was attempted as well, but this failed to unrelated issues: paths were messed up for git_version.sh, and the atombios includes horribly break due to C++isms. We will need further discussions as to how to proceed here. The messed paths are easy to fix, the atombios mess is something else entirely. The big changes for this patch are: * xf86_ansic.c is no longer included but changed to unistd.h, following original patch. This break against already including xf86.h, as this still includes xf86_ansic.c, and several common c functions are redefined there. The solution is to either #ifdef out the unistd.h inclusion on _XF86_ANSIC_H (the define wrapping xf86_ansic.c -- done in my unichrome), or include standard headers before xf86.h. Since the latter is much cleaner and nicer, this was chosen. * xf86strdup can be replaced by xstrdup. Egberts code referenced the second as well, and i happened to stumble over it. The difference is probably usage of xalloc versus alloc. Please verify that this patch builds against the completely libcunwrapped server. Thanks, Luc Verhaegen. SUSE/Novell X Driver Developer. -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
These things work better when patches are actually attached. Luc Verhaegen. SUSE/Novell X Driver Developer.
On Tue, Dec 11, 2007 at 11:50:37AM +0100, Luc Verhaegen. wrote:
These things work better when patches are actually attached.
Luc Verhaegen. SUSE/Novell X Driver Developer.
Egbert pushed a different fix already. Thanks, Luc Verhaegen. SUSE/Novell X Driver Developer. -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
participants (4)
-
Luc Verhaegen
-
Luc Verhaegen.
-
Matthias Hopf
-
raiden@server.boros.com