Updating python-pytest-cov
Hi! I need a slightly newer version of python-pytest-cov in Factory for updating python-botocore to its current version, namely 2.12.1. Is there anything that currently keeps us from updating python-pytest-cov to a newer version or even the latest upstream version or can I just go ahead? Thanks, Adrian
Helo Adrian, Am Mittwoch, 27. Oktober 2021, 22:28:24 CEST schrieb John Paul Adrian Glaubitz:
Is there anything that currently keeps us from updating python-pytest-cov to a newer version or even the latest upstream version or can I just go ahead?
As this package was mentioned in the weekly update report from Matej I see no point in not updating it.... Cheers Axel
Hi, Am 27.10.21 um 22:28 schrieb John Paul Adrian Glaubitz:
Hi!
I need a slightly newer version of python-pytest-cov in Factory for updating python-botocore to its current version, namely 2.12.1.
Is there anything that currently keeps us from updating python-pytest-cov to a newer version or even the latest upstream version or can I just go ahead?
I don't think that there is any objection to updating pytest-cov for TW. However, I would like to mention that you probably don't really need pytest-cov for botocore. You don't have to check code coverage during the rpmbuild. You just have to make sure that: * There is no runtime dependency on pytest-cov by setup(install_requires=...), which could propagate into the egg-info/requires.txt * There is no pytest --cov* option added by some addopts option in pyproject.toml, .pytest.ini, setup.cfg, etc. If there is, this usually can be patched out. AFAICS, that is all fullfilled by botocore. An rpmbuild without pytest-cov should not fail.
Thanks, Adrian
Regards, Ben
Hi Ben! On 10/28/21 10:18, Ben Greiner wrote:
I don't think that there is any objection to updating pytest-cov for TW. However, I would like to mention that you probably don't really need pytest-cov for botocore. You don't have to check code coverage during the rpmbuild.
You just have to make sure that: * There is no runtime dependency on pytest-cov by setup(install_requires=...), which could propagate into the egg-info/requires.txt * There is no pytest --cov* option added by some addopts option in pyproject.toml, .pytest.ini, setup.cfg, etc. If there is, this usually can be patched out.
AFAICS, that is all fullfilled by botocore. An rpmbuild without pytest-cov should not fail.
Thanks for the hints. I tried this before but the testsuite hangs right away when being called with %pytest: [ 8s] + PYTHONPATH=/home/abuild/rpmbuild/BUILDROOT/python-botocore-1.22.3-0.x86_64/usr/lib/python3.9/site-packages [ 8s] + PYTHONDONTWRITEBYTECODE=1 [ 8s] + pytest-3.9 --ignore=_build. --ignore=_build.python39 --ignore=_build.python38 -v [ 9s] ============================= test session starts ============================== [ 9s] platform linux -- Python 3.9.7, pytest-6.2.5, py-1.10.0, pluggy-1.0.0 -- /usr/bin/python3.9 [ 9s] cachedir: .pytest_cache [ 9s] rootdir: /home/abuild/rpmbuild/BUILD/botocore-1.22.3, configfile: pyproject.toml Current packaging source in [1]. Any idea? Adrian
[1] https://build.opensuse.org/package/show/home:glaubitz:branches:devel:languag...
participants (3)
-
Axel Braun
-
Ben Greiner
-
John Paul Adrian Glaubitz