David kiarie wrote:

Hi there,

As I said last time the goals of the project changed slightly because there was not a lot of enthusiasm by xen developers on snapshot support in xen

Yeah, that is unfortunate. But as you say, we anticipated this early on and knew there would be plenty of opportunities to contribute elsewhere in the libvirt libxl driver.

so after the patch I wrote for libvirt I moved on and I am now writing a xen-xl parser for libvirt.

This week I refactored the code in xen_xm.c as I want to reuse. Reading directly from the diff, here is what I have: For the function xenParseXM, I split it into xenParseXMGeneral; parse the general configs such as uuid, OS type etc, tagged for reuse. xenParseXMMem; parses memory configuration options, tagged for reuse in the xen-xl parser. xenParseXMVif ;parses the virtual frame-buffer configuration, I will also reuse this one. xenParseXMDisk ; parse the disk configuration but this will have to be redone. xenParseXMPCI; parses the pci devices config, I will reuse this at first but I will redo it latter. xenParseXMSerial; parses the serial devices config, also to be reused.

More generally, this one could be xenParseXMCharDev and handle parsing consoles, serial port, parallel ports, and other such character devices.

xenParseXMActions; parses the actions the take place at certain events, that is power_off, c xenParseXMCPU ; parses the cpu allocation, also to be reused. xenParseXMOS ; parses the OS config options for HVM and paravirtualized domains. xenParseXMVif ;parse the xm network configuration but will have to be redone. For the function xenFormatXM, I split it into a similar set of functions.

Functions used by both converters could be wrapped in something like xenParseConfigCommon. You can then call it in the converters, instead of calling each function individually. Saves a bit of code duplication.

Next week, I move to the xen-xl parser where I will start by writing the missing functions such as xenParseXLDisk and xenParseXLVif.I will also write xenParseXLGraphicsSplice for latter use.

I think you should post the refactoring work upstream once you are satisfied with it and 'make syntax-check;make check' passes. All of that work logically belongs together in one patch series, which simply refactors the code. Introduction of the xen-xl converter, along with functions to parse xl disk and vif config, can be sent in a follow-up patch series. Does that make sense? Thanks for the report David! Regards, Jim -- To unsubscribe, e-mail: opensuse-project+unsubscribe@opensuse.org To contact the owner, email: opensuse-project+owner@opensuse.org